Merge pull request #1585 from stan-dev/jacobian-reserved-parser

Add jacobian to special parser reserved error messaging

Author: WardBrian

src/frontend/parser.messages

@@ -258,6 +258,7 @@ reserved_word:
   | REJECT { "reject", $loc, false }
   | FATAL_ERROR { "fatal_error", $loc, false }
   | TARGET { "target", $loc, false }
+  | JACOBIAN { "jacobian", $loc, false }
   | PROFILE { "profile", $loc, false }
   | TUPLE { "tuple", $loc, true }
   | OFFSET { "offset", $loc, false }

src/frontend/parser.mly

@@ -0,0 +1,5 @@
+data {
+  real jacobian;
+}
+model {
+}

test/integration/bad/reserved/jacobian.stan

@@ -212,6 +212,18 @@ Syntax error in 'int.stan', line 2, column 7 to column 10, parsing error:
    -------------------------------------------------
 
 Ill-formed identifier. Expected a new identifier but found reserved keyword "int".
+[exit 1]
+  $ ../../../../../install/default/bin/stanc jacobian.stan
+Syntax error in 'jacobian.stan', line 2, column 7 to column 15, parsing error:
+   -------------------------------------------------
+     1:  data {
+     2:    real jacobian;
+                ^
+     3:  }
+     4:  model {
+   -------------------------------------------------
+
+Ill-formed identifier. Expected a new identifier but found reserved keyword "jacobian".
 [exit 1]
   $ ../../../../../install/default/bin/stanc matrix.stan
 Syntax error in 'matrix.stan', line 2, column 7 to column 13, parsing error:
@@ -401,6 +413,18 @@ Syntax error in 'sum_to_zero_vector.stan', line 2, column 7 to column 25, parsin
    -------------------------------------------------
 
 Ill-formed identifier. Expected a new identifier but found reserved keyword "sum_to_zero_vector".
+[exit 1]
+  $ ../../../../../install/default/bin/stanc target.stan
+Syntax error in 'target.stan', line 2, column 7 to column 13, parsing error:
+   -------------------------------------------------
+     1:  data {
+     2:    real target;
+                ^
+     3:  }
+     4:  model {
+   -------------------------------------------------
+
+Ill-formed identifier. Expected a new identifier but found reserved keyword "target".
 [exit 1]
   $ ../../../../../install/default/bin/stanc then.stan
 Semantic error in 'then.stan', line 2, column 7 to column 11:

test/integration/bad/reserved/stanc.expected

@@ -0,0 +1,5 @@
+data {
+  real target;
+}
+model {
+}

test/integration/bad/reserved/target.stan

@@ -470,5 +470,5 @@ Flags not used elsewhere in the tests
 
   Ill-formed program. Expected "functions {", "transformed data {", "parameters {",
   "transformed parameters {", "model {", or "generated quantities {".
-  (Parse error state 410)
+  (Parse error state 411)
   [1]