Merge pull request #1594 from ishaan-arora-1/fix/use-list-is-empty

Replace O(n) List.length comparisons with O(1) List.is_empty

Author: WardBrian

src/analysis_and_optimization/Optimize.ml

@@ -799,10 +799,10 @@ let dead_code_elimination (mir : Program.Typed.t) =
           else For {loopvar; lower; upper; body}
       | Profile (name, l) ->
           let l' = List.filter ~f:(fun x -> x.pattern <> Skip) l in
-          if List.length l' = 0 then Skip else Profile (name, l')
+          if List.is_empty l' then Skip else Profile (name, l')
       | Block l ->
           let l' = List.filter ~f:(fun x -> x.pattern <> Skip) l in
-          if List.length l' = 0 then Skip else Block l'
+          if List.is_empty l' then Skip else Block l'
       | SList l ->
           let l' = List.filter ~f:(fun x -> x.pattern <> Skip) l in
           SList l' in
@@ -1023,7 +1023,7 @@ let lazy_code_motion ?(preserve_stability = false) (mir : Program.Typed.t) =
           (Map.mapi expression_map ~f:(fun ~key ~data ->
                {key with pattern= Var data})) in
       let f = expr_subst_stmt_except_initial_assign expr_map in
-      if List.length assignments_to_add_to_s = 0 then
+      if List.is_empty assignments_to_add_to_s then
         (f Stmt.{pattern= stmt; meta= Location_span.empty}).pattern
       else
         SList

src/frontend/Warnings.ml

@@ -13,5 +13,5 @@ let pp ?printed_filename ppf (span, message) =
   Fmt.pf ppf "@[<v4>%a%a%a@]@]" purple "Warning" maybe_loc span Fmt.text message
 
 let pp_warnings ?printed_filename ppf warnings =
-  if List.length warnings > 0 then
+  if not (Core.List.is_empty warnings) then
     Fmt.(pf ppf "@[<v>%a@]@\n" (list ~sep:cut (pp ?printed_filename)) warnings)