Merge branch 'develop' into fix/double-rpath

Author: WardBrian

stan/math/prim/prob/bernoulli_cdf.hpp

@@ -34,7 +34,7 @@ return_type_t<T_prob> bernoulli_cdf(const T_n& n, const T_prob& theta) {
   check_consistent_sizes(function, "Random variable", n,
                          "Probability parameter", theta);
   T_theta_ref theta_ref = theta;
-  const auto& n_arr = as_array_or_scalar(n);
+  const auto& n_arr = as_value_column_array_or_scalar(n);
   const auto& theta_arr = as_value_column_array_or_scalar(theta_ref);
   check_bounded(function, "Probability parameter", theta_arr, 0.0, 1.0);
 

stan/math/prim/prob/bernoulli_lccdf.hpp

@@ -35,7 +35,7 @@ return_type_t<T_prob> bernoulli_lccdf(const T_n& n, const T_prob& theta) {
   check_consistent_sizes(function, "Random variable", n,
                          "Probability parameter", theta);
   T_theta_ref theta_ref = theta;
-  const auto& n_arr = as_array_or_scalar(n);
+  const auto& n_arr = as_value_column_array_or_scalar(n);
   const auto& theta_arr = as_value_column_array_or_scalar(theta_ref);
   check_bounded(function, "Probability parameter", theta_arr, 0.0, 1.0);
 

stan/math/prim/prob/bernoulli_lcdf.hpp

@@ -33,7 +33,7 @@ return_type_t<T_prob> bernoulli_lcdf(const T_n& n, const T_prob& theta) {
   check_consistent_sizes(function, "Random variable", n,
                          "Probability parameter", theta);
   T_theta_ref theta_ref = theta;
-  const auto& n_arr = as_array_or_scalar(n);
+  const auto& n_arr = as_value_column_array_or_scalar(n);
   const auto& theta_arr = as_value_column_array_or_scalar(theta_ref);
   check_bounded(function, "Probability parameter", theta_arr, 0.0, 1.0);
 

test/unit/math/mix/fun/eigendecompose_part1_test.cpp

@@ -0,0 +1,22 @@
+#include <test/unit/math/test_ad.hpp>
+#include <stdexcept>
+
+TEST(mathMixFun, eigendecompose) {
+  auto f = [](const auto& x) {
+    using stan::math::eigendecompose;
+    return std::get<0>(eigendecompose(x));
+  };
+  auto g = [](const auto& x) {
+    using stan::math::eigendecompose;
+    return std::get<1>(eigendecompose(x));
+  };
+  for (const auto& x : stan::test::square_test_matrices(0, 2)) {
+    stan::test::expect_ad(f, x);
+    stan::test::expect_ad(g, x);
+  }
+
+  Eigen::MatrixXd a32(3, 2);
+  a32 << 3, -5, 7, -7.2, 9.1, -6.3;
+  EXPECT_THROW(f(a32), std::invalid_argument);
+  EXPECT_THROW(g(a32), std::invalid_argument);
+}

…nit/math/mix/fun/eigendecompose_test.cpp …th/mix/fun/eigendecompose_part2_test.cpptest/unit/math/mix/fun/eigendecompose_test.cpp renamed to test/unit/math/mix/fun/eigendecompose_part2_test.cpp test/unit/math/mix/fun/eigendecompose_test.cpp renamed to test/unit/math/mix/fun/eigendecompose_part2_test.cpp

@@ -1,26 +1,6 @@
 #include <test/unit/math/test_ad.hpp>
 #include <stdexcept>
 
-TEST(mathMixFun, eigendecompose) {
-  auto f = [](const auto& x) {
-    using stan::math::eigendecompose;
-    return std::get<0>(eigendecompose(x));
-  };
-  auto g = [](const auto& x) {
-    using stan::math::eigendecompose;
-    return std::get<1>(eigendecompose(x));
-  };
-  for (const auto& x : stan::test::square_test_matrices(0, 2)) {
-    stan::test::expect_ad(f, x);
-    stan::test::expect_ad(g, x);
-  }
-
-  Eigen::MatrixXd a32(3, 2);
-  a32 << 3, -5, 7, -7.2, 9.1, -6.3;
-  EXPECT_THROW(f(a32), std::invalid_argument);
-  EXPECT_THROW(g(a32), std::invalid_argument);
-}
-
 TEST(mathMixFun, eigendecomposeComplex) {
   auto f = [](const auto& x) {
     using stan::math::eigendecompose;