Skip to content

Commit c49e8ae

Browse files
committed
Fix eigenvalues_sym return type
1 parent 98117fa commit c49e8ae

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

stan/math/prim/fun/eigenvalues_sym.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ namespace math {
2121
*/
2222
template <typename EigMat, require_eigen_matrix_dynamic_t<EigMat>* = nullptr,
2323
require_not_st_var<EigMat>* = nullptr>
24-
Eigen::Matrix<value_type_t<EigMat>, Eigen::Dynamic, 1> eigenvalues_sym(
25-
const EigMat& m) {
24+
Eigen::Vector<value_type_t<EigMat>, -1> eigenvalues_sym(const EigMat& m) {
2625
using PlainMat = plain_type_t<EigMat>;
2726
const PlainMat& m_eval = m;
2827
check_nonzero_size("eigenvalues_sym", "m", m_eval);

stan/math/rev/fun/eigenvalues_sym.hpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,8 @@ namespace math {
2323
*/
2424
template <typename T, require_rev_matrix_t<T>* = nullptr>
2525
inline auto eigenvalues_sym(const T& m) {
26-
using return_t = return_var_matrix_t<T>;
27-
if (unlikely(m.size() == 0)) {
28-
return return_t(m);
29-
}
26+
using return_t = return_var_matrix_t<Eigen::VectorXd, T>;
27+
check_nonzero_size("eigenvalues_sym", "m", m);
3028
check_symmetric("eigenvalues_sym", "m", m);
3129

3230
auto arena_m = to_arena(m);

0 commit comments

Comments
 (0)