Review comments

Author: andrjohns

stan/math/opencl/rev/matrix_power.hpp

@@ -34,15 +34,17 @@ inline var_value<matrix_cl<double>> matrix_power(const var_value<T>& M,
   if (M.size() == 0)
     return M;
 
+  size_t N = M.rows();
+
   if (n == 0) {
-    return diag_matrix(constant(1.0, M.rows(), 1));
+    return diag_matrix(constant(1.0, N, 1));
   }
   if (n == 1) {
     return M;
   }
 
   arena_t<std::vector<matrix_cl<double>>> arena_powers(n + 1);
-  arena_powers[0] = diag_matrix(constant(1.0, M.rows(), 1));
+  arena_powers[0] = diag_matrix(constant(1.0, N, 1));
   arena_powers[1] = M.val();
   for (size_t i = 2; i <= n; ++i) {
     arena_powers[i] = arena_powers[1] * arena_powers[i - 1];

stan/math/prim/fun/lb_free.hpp

@@ -82,9 +82,10 @@ inline auto lb_free(T&& y, L&& lb) {
  */
 template <typename T, typename L, require_not_std_vector_t<L>* = nullptr>
 inline auto lb_free(const std::vector<T> y, const L& lb) {
-  std::vector<decltype(lb_free(y[0], lb))> ret(y.size());
+  auto&& lb_ref = to_ref(lb);
+  std::vector<decltype(lb_free(y[0], lb_ref))> ret(y.size());
   std::transform(y.begin(), y.end(), ret.begin(),
-                 [&lb](auto&& yy) { return lb_free(yy, lb); });
+                 [&lb_ref](auto&& yy) { return lb_free(yy, lb_ref); });
   return ret;
 }
 

stan/math/prim/prob/gaussian_dlm_obs_rng.hpp

@@ -95,23 +95,24 @@ inline Eigen::MatrixXd gaussian_dlm_obs_rng(const Eigen::MatrixXd &F,
   static const char *function = "gaussian_dlm_obs_rng";
 
   int r = F.cols();  // number of variables
+  int n = G.rows();  // number of states
 
-  check_size_match(function, "rows of F", F.rows(), "rows of G", G.rows());
+  check_size_match(function, "rows of F", F.rows(), "rows of G", n);
   check_finite(function, "F", F);
   check_square(function, "G", G);
   check_finite(function, "G", G);
-  check_size_match(function, "rows of V", V.rows(), "cols of F", F.cols());
+  check_size_match(function, "rows of V", V.rows(), "cols of F", r);
   check_finite(function, "V", V);
   check_positive(function, "V rows", V.rows());
   check_symmetric(function, "V", V);
-  check_size_match(function, "rows of W", W.rows(), "rows of G", G.rows());
+  check_size_match(function, "rows of W", W.rows(), "rows of G", n);
   check_finite(function, "W", W);
   check_positive(function, "W rows", W.rows());
   check_symmetric(function, "W", W);
-  check_size_match(function, "rows of W", W.rows(), "rows of G", G.rows());
-  check_size_match(function, "size of m0", m0.size(), "rows of G", G.rows());
+  check_size_match(function, "rows of W", W.rows(), "rows of G", n);
+  check_size_match(function, "size of m0", m0.size(), "rows of G", n);
   check_finite(function, "m0", m0);
-  check_size_match(function, "rows of C0", C0.rows(), "rows of G", G.rows());
+  check_size_match(function, "rows of C0", C0.rows(), "rows of G", n);
   check_finite(function, "C0", C0);
   check_positive(function, "C0 rows", C0.rows());
   check_symmetric(function, "C0", C0);