Merge pull request #2933 from stan-dev/compiler-warnings

Cleanup compiler warnings: unused variables/typedefs, uninitialised vars, etc.

Author: WardBrian

stan/math/fwd/fun/mdivide_left.hpp

@@ -60,9 +60,6 @@ template <typename T1, typename T2,
 inline Eigen::Matrix<value_type_t<T2>, T1::RowsAtCompileTime,
                      T2::ColsAtCompileTime>
 mdivide_left(const T1& A, const T2& b) {
-  constexpr int S1 = T1::RowsAtCompileTime;
-  constexpr int C2 = T2::ColsAtCompileTime;
-
   check_square("mdivide_left", "A", A);
   check_multiplicable("mdivide_left", "A", A, "b", b);
   if (A.size() == 0) {

stan/math/fwd/fun/mdivide_left_tri_low.hpp

@@ -56,7 +56,6 @@ inline Eigen::Matrix<value_type_t<T2>, T1::RowsAtCompileTime,
                      T2::ColsAtCompileTime>
 mdivide_left_tri_low(const T1& A, const T2& b) {
   constexpr int S1 = T1::RowsAtCompileTime;
-  constexpr int C2 = T2::ColsAtCompileTime;
 
   check_square("mdivide_left_tri_low", "A", A);
   check_multiplicable("mdivide_left_tri_low", "A", A, "b", b);

stan/math/fwd/fun/mdivide_right.hpp

@@ -97,7 +97,6 @@ inline Eigen::Matrix<value_type_t<EigMat2>, EigMat1::RowsAtCompileTime,
 mdivide_right(const EigMat1& A, const EigMat2& b) {
   using T = typename value_type_t<EigMat2>::Scalar;
   constexpr int R1 = EigMat1::RowsAtCompileTime;
-  constexpr int C1 = EigMat1::ColsAtCompileTime;
   constexpr int R2 = EigMat2::RowsAtCompileTime;
   constexpr int C2 = EigMat2::ColsAtCompileTime;
 

stan/math/fwd/fun/mdivide_right_tri_low.hpp

@@ -98,7 +98,6 @@ inline Eigen::Matrix<value_type_t<EigMat2>, EigMat1::RowsAtCompileTime,
 mdivide_right_tri_low(const EigMat1& A, const EigMat2& b) {
   using T = typename value_type_t<EigMat2>::Scalar;
   constexpr int R1 = EigMat1::RowsAtCompileTime;
-  constexpr int C1 = EigMat1::ColsAtCompileTime;
   constexpr int R2 = EigMat2::RowsAtCompileTime;
   constexpr int C2 = EigMat2::ColsAtCompileTime;
   check_square("mdivide_right_tri_low", "b", b);

stan/math/opencl/kernel_generator/broadcast.hpp

@@ -98,7 +98,6 @@ class broadcast_
    * @return pair of indices - bottom and top diagonal
    */
   inline std::pair<int, int> extreme_diagonals() const {
-    int bottom, top;
     std::pair<int, int> arg_diags
         = this->template get_arg<0>().extreme_diagonals();
     return {Colwise ? std::numeric_limits<int>::min() : arg_diags.first,

stan/math/opencl/mrrr.hpp

@@ -373,7 +373,6 @@ inline void mrrr_cl(const Eigen::Ref<const Eigen::VectorXd> diagonal,
       cluster_end--;  // now this is the index of the last element of the
                       // cluster
       if (cluster_end > i) {  // cluster
-        double_d a = high[cluster_end - 1], b = low[cluster_end];
         double_d max_shift
             = (high[cluster_end - 1] - low[cluster_end]) / min_rel_sep;
         double_d next_shift;
@@ -396,7 +395,6 @@ inline void mrrr_cl(const Eigen::Ref<const Eigen::VectorXd> diagonal,
 
         i = cluster_end;
       } else {  // isolated eigenvalue
-        int twist_idx;
         const double_d low_gap
             = i == block.start
                   ? double_d(std::numeric_limits<double>::infinity())

stan/math/opencl/prim/bernoulli_cdf.hpp

@@ -33,7 +33,6 @@ return_type_t<T_prob_cl> bernoulli_cdf(const T_n_cl& n,
   using T_partials_return = partials_return_t<T_prob_cl>;
   using std::isnan;
   constexpr bool is_n_vector = !is_stan_scalar<T_n_cl>::value;
-  constexpr bool is_theta_vector = !is_stan_scalar<T_prob_cl>::value;
 
   check_consistent_sizes(function, "Random variable", n,
                          "Probability parameter", theta);

stan/math/opencl/prim/bernoulli_lccdf.hpp

@@ -34,7 +34,6 @@ return_type_t<T_prob_cl> bernoulli_lccdf(const T_n_cl& n,
   using T_partials_return = partials_return_t<T_prob_cl>;
   using std::isnan;
   constexpr bool is_n_vector = !is_stan_scalar<T_n_cl>::value;
-  constexpr bool is_theta_vector = !is_stan_scalar<T_prob_cl>::value;
 
   check_consistent_sizes(function, "Random variable", n,
                          "Probability parameter", theta);

stan/math/opencl/prim/bernoulli_lcdf.hpp

@@ -34,7 +34,6 @@ return_type_t<T_prob_cl> bernoulli_lcdf(const T_n_cl& n,
   using T_partials_return = partials_return_t<T_prob_cl>;
   using std::isnan;
   constexpr bool is_n_vector = !is_stan_scalar<T_n_cl>::value;
-  constexpr bool is_theta_vector = !is_stan_scalar<T_prob_cl>::value;
 
   check_consistent_sizes(function, "Random variable", n,
                          "Probability parameter", theta);

stan/math/opencl/prim/bernoulli_logit_lpmf.hpp

@@ -32,7 +32,6 @@ return_type_t<T_prob_cl> bernoulli_logit_lpmf(const T_n_cl& n,
   using T_partials_return = partials_return_t<T_prob_cl>;
   using std::isnan;
   constexpr bool is_n_vector = !is_stan_scalar<T_n_cl>::value;
-  constexpr bool is_theta_vector = !is_stan_scalar<T_prob_cl>::value;
 
   check_consistent_sizes(function, "Random variable", n,
                          "Probability parameter", theta);