Skip to content

Commit 7730846

Browse files
committed
Update qr functions per review
1 parent 113db1c commit 7730846

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

stan/math/prim/fun/qr_thin.hpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,8 @@ qr_thin(const EigMat& m) {
3636
}
3737
}
3838
matrix_t R = qr.matrixQR().topLeftCorner(min_size, m.cols());
39-
for (int i = 0; i < min_size; i++) {
40-
for (int j = 0; j < i; j++) {
41-
R.coeffRef(i, j) = 0.0;
42-
}
39+
R.template triangularView<Eigen::StrictlyLower>().setZero();
40+
for (int i = 0; i < min_size; ++i) {
4341
if (R(i, i) < 0) {
4442
R.row(i) *= -1.0;
4543
}

stan/math/prim/fun/qr_thin_R.hpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,8 @@ Eigen::Matrix<value_type_t<EigMat>, Eigen::Dynamic, Eigen::Dynamic> qr_thin_R(
2525
qr.compute(m);
2626
const int min_size = std::min(m.rows(), m.cols());
2727
matrix_t R = qr.matrixQR().topLeftCorner(min_size, m.cols());
28-
for (int i = 0; i < min_size; i++) {
29-
for (int j = 0; j < i; j++) {
30-
R.coeffRef(i, j) = 0.0;
31-
}
28+
R.template triangularView<Eigen::StrictlyLower>().setZero();
29+
for (int i = 0; i < min_size; ++i) {
3230
if (R(i, i) < 0) {
3331
R.row(i) *= -1.0;
3432
}

0 commit comments

Comments
 (0)