Clean up test

Author: WardBrian

src/test/interface/permissions_test.cpp

@@ -1,23 +1,20 @@
-#include <cmdstan/stansummary_helper.hpp>
-#include <stan/io/stan_csv_reader.hpp>
-#include <stan/services/error_codes.hpp>
 #include <test/utility.hpp>
 #include <gtest/gtest.h>
 
 using cmdstan::test::convert_model_path;
+using cmdstan::test::run_command;
+using cmdstan::test::temporary_unwritable_file;
 
-TEST(interface, unwritable_file) {
-  std::string model = convert_model_path(
-      std::vector{"src", "test", "test-models", "test_model"});
-  std::string output
-      = convert_model_path(std::vector{"test", "output_unwritable.csv"});
+TEST(interface, fails_when_output_is_unwritable) {
+  // makes a file without the w bit set
+  temporary_unwritable_file file(
+      convert_model_path(std::vector{"test", "output_unwritable.csv"}));
 
-  cmdstan::test::temporary_unwritable_file guard(output);
+  std::string command = convert_model_path(std::vector{
+                            "src", "test", "test-models", "test_model"})
+                        + " sample output file=" + file.filename;
 
-  std::string command
-      = model + " sample num_warmup=1 num_samples=1 output file=" + output;
-
-  cmdstan::test::run_command_output out = cmdstan::test::run_command(command);
+  auto out = run_command(command);
   EXPECT_IN_STRING("Permission denied", out.output);
   EXPECT_TRUE(out.hasError);
 }

src/test/utility.hpp

@@ -343,8 +343,11 @@ void make_writable(const std::string &filename) {
 }  // namespace internal
 
 struct temporary_unwritable_file {
-  std::string filename;
-  temporary_unwritable_file(const std::string &filename) : filename(filename) {
+ public:
+  const std::string filename;
+
+  explicit temporary_unwritable_file(std::string filename)
+      : filename(filename) {
     {
       // this will create the file if it does not exist
       std::ofstream ofs(filename);
@@ -353,6 +356,7 @@ struct temporary_unwritable_file {
     EXPECT_TRUE(file_exists(filename));
     internal::make_unwritable(filename);
   }
+
   ~temporary_unwritable_file() noexcept(false) {
     internal::make_writable(filename);
     EXPECT_EQ(remove(filename.c_str()), 0);