feat(observability): Min/Max acceptance tests (#805)

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>

Author: Fyusel

stackit/internal/services/observability/alertgroup/resource.go

@@ -175,6 +175,7 @@ func (a *alertGroupResource) Schema(_ context.Context, _ resource.SchemaRequest,
 			"interval": schema.StringAttribute{
 				Description: descriptions["interval"],
 				Optional:    true,
+				Computed:    true,
 				Validators: []validator.String{
 					validate.ValidDurationString(),
 				},

stackit/internal/services/observability/instance/datasource.go

@@ -409,6 +409,12 @@ func (d *instanceDataSource) Read(ctx context.Context, req datasource.ReadReques
 		return
 	}
 
+	metricsRetentionResp, err := d.client.GetMetricsStorageRetention(ctx, instanceId, projectId).Execute()
+	if err != nil {
+		core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading instance", fmt.Sprintf("Calling API to get metrics retention: %v", err))
+		return
+	}
+
 	alertConfigResp, err := d.client.GetAlertConfigs(ctx, instanceId, projectId).Execute()
 	if err != nil {
 		core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading instance", fmt.Sprintf("Calling API to get alert config: %v", err))
@@ -421,18 +427,49 @@ func (d *instanceDataSource) Read(ctx context.Context, req datasource.ReadReques
 		core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading instance", fmt.Sprintf("Processing API payload: %v", err))
 		return
 	}
+
+	// Set state to instance populated data
+	diags = resp.State.Set(ctx, model)
+	resp.Diagnostics.Append(diags...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
 	err = mapACLField(aclListResp, &model)
 	if err != nil {
 		core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading instance", fmt.Sprintf("Processing API response for the ACL: %v", err))
 		return
 	}
+
+	// Set state to fully populated data
+	diags = setACL(ctx, &resp.State, &model)
+	resp.Diagnostics.Append(diags...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	// Map response body to schema
+	err = mapMetricsRetentionField(metricsRetentionResp, &model)
+	if err != nil {
+		core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading instance", fmt.Sprintf("Processing API response for the metrics retention: %v", err))
+		return
+	}
+
+	// Set state to fully populated data
+	diags = setMetricsRetentions(ctx, &resp.State, &model)
+	resp.Diagnostics.Append(diags...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
 	err = mapAlertConfigField(ctx, alertConfigResp, &model)
 	if err != nil {
 		core.LogAndAddError(ctx, &resp.Diagnostics, "Error creating instance", fmt.Sprintf("Processing API response for the alert config: %v", err))
 		return
 	}
 
-	diags = resp.State.Set(ctx, model)
+	// Set state to fully populated data
+	diags = setAlertConfig(ctx, &resp.State, &model)
 	resp.Diagnostics.Append(diags...)
 	if resp.Diagnostics.HasError() {
 		return

stackit/internal/services/observability/log-alertgroup/resource.go

@@ -175,6 +175,7 @@ func (l *logAlertGroupResource) Schema(_ context.Context, _ resource.SchemaReque
 			"interval": schema.StringAttribute{
 				Description: descriptions["interval"],
 				Optional:    true,
+				Computed:    true,
 				Validators: []validator.String{
 					validate.ValidDurationString(),
 				},