Skip to content

Commit a95e6bc

Browse files
authored
Enable js_outputs of proto_ts_library (#257)
This was somewhat arbitrarily disabled. As it turns out, need to propagate the js files.
1 parent c7b058d commit a95e6bc

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

rules/ts/proto_ts_library.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ def _proto_ts_library_impl(ctx):
3737
dts_outputs.append(
3838
ctx.actions.declare_file(base + ".d.ts", sibling = f),
3939
)
40-
# js_outputs.append(
41-
# ctx.actions.declare_file(base + ".js", sibling = f),
42-
# )
40+
js_outputs.append(
41+
ctx.actions.declare_file(base + ".js", sibling = f),
42+
)
4343

4444
# all outputs (.d.ts + .js)
4545
outputs = js_outputs + dts_outputs
@@ -98,7 +98,7 @@ proto_ts_library = rule(
9898
),
9999
"tsc": attr.label(
100100
allow_files = True,
101-
cfg = "host",
101+
cfg = "exec",
102102
mandatory = True,
103103
doc = "typescript compiler executable",
104104
executable = True,

0 commit comments

Comments
 (0)