Skip to content

Commit 7b923b8

Browse files
authored
Incremental update bazel-gazelle (#286)
* Incremental update bazel-gazelle to end of 2021 * Upgrade past bazel-gazelle #1158 * Bump to 6adf61901eee7e6de7d8ab3af0fc15d06982ad34
1 parent 81f9b76 commit 7b923b8

4 files changed

Lines changed: 38 additions & 23 deletions

File tree

deps/BUILD.bazel

Lines changed: 12 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -109,30 +109,23 @@ proto_dependency(
109109
visibility = ["//visibility:public"],
110110
)
111111

112-
# Branch: master
113-
# Commit: 425d85daecb9aeffa1ae24b83df7b97b534dcf05
114-
# Date: 2021-10-29 00:25:25 +0000 UTC
115-
# URL: https://github.com/bazelbuild/bazel-gazelle/commit/425d85daecb9aeffa1ae24b83df7b97b534dcf05
116-
#
117-
# Stardoc generates repository.md (#1123)
118-
#
119-
# * Stardoc generates repository.md
112+
# Commit: 6adf61901eee7e6de7d8ab3af0fc15d06982ad34
113+
# Date: 2022-03-16 21:48:10 +0000 UTC
114+
# URL: https://github.com/bazelbuild/bazel-gazelle/commit/6adf61901eee7e6de7d8ab3af0fc15d06982ad34
120115
#
121-
# This is a mirror of the content in repository.rst, allowing us to manually inspect the delta between them.
122-
# As soon as we are satisfied that the generated content is correct, we'll delete repository.rst and update any links to it.
123-
#
124-
# Technique: copied doc strings out of existing rst file into the starlark files. Transcribed rst syntax to markdown.
125-
#
126-
# * Replace repository.rst content with link to markdown version
127-
# Size: 1416940 (1.4 MB)
116+
# ci: Add gazelle check (#1203)
117+
# Size: 1432187 (1.4 MB)
128118
proto_dependency(
129119
name = "bazel_gazelle",
130120
patch_args = ["-p1"],
131-
patches = ["@build_stack_rules_proto//third_party:bazel-gazelle-PR1274.patch"],
121+
patches = [
122+
"@build_stack_rules_proto//third_party:bazel-gazelle-PR1274.patch",
123+
"@build_stack_rules_proto//third_party:bazel-gazelle-revert-1152.patch",
124+
],
132125
repository_rule = "http_archive",
133-
sha256 = "cb05501bd37e2cbfdea8e23b28e5a7fe4ff4f12cef30eeb1924a0b8c3c0cea61",
134-
strip_prefix = "bazel-gazelle-425d85daecb9aeffa1ae24b83df7b97b534dcf05",
135-
urls = ["https://github.com/bazelbuild/bazel-gazelle/archive/425d85daecb9aeffa1ae24b83df7b97b534dcf05.tar.gz"],
126+
sha256 = "9a67de0258804915cda489cf0925d9b5894ee77c021a83cee9a2f405b2a95048",
127+
strip_prefix = "bazel-gazelle-6adf61901eee7e6de7d8ab3af0fc15d06982ad34",
128+
urls = ["https://github.com/bazelbuild/bazel-gazelle/archive/6adf61901eee7e6de7d8ab3af0fc15d06982ad34.tar.gz"],
136129
deps = [":io_bazel_rules_go"],
137130
)
138131

deps/core_deps.bzl

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,14 @@ def bazel_gazelle():
3030
_maybe(
3131
http_archive,
3232
name = "bazel_gazelle",
33-
sha256 = "cb05501bd37e2cbfdea8e23b28e5a7fe4ff4f12cef30eeb1924a0b8c3c0cea61",
34-
strip_prefix = "bazel-gazelle-425d85daecb9aeffa1ae24b83df7b97b534dcf05",
33+
sha256 = "9a67de0258804915cda489cf0925d9b5894ee77c021a83cee9a2f405b2a95048",
34+
strip_prefix = "bazel-gazelle-6adf61901eee7e6de7d8ab3af0fc15d06982ad34",
3535
urls = [
36-
"https://github.com/bazelbuild/bazel-gazelle/archive/425d85daecb9aeffa1ae24b83df7b97b534dcf05.tar.gz",
36+
"https://github.com/bazelbuild/bazel-gazelle/archive/6adf61901eee7e6de7d8ab3af0fc15d06982ad34.tar.gz",
3737
],
3838
patches = [
3939
"@build_stack_rules_proto//third_party:bazel-gazelle-PR1274.patch",
40+
"@build_stack_rules_proto//third_party:bazel-gazelle-revert-1152.patch",
4041
],
4142
patch_args = [
4243
"-p1",

third_party/BUILD.bazel

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,13 @@ filegroup(
33
srcs = [
44
"BUILD.bazel",
55
"bazel-gazelle-PR1274.patch",
6+
"bazel-gazelle-revert-1152.patch",
67
"zlib.BUILD",
78
],
89
visibility = ["//:__pkg__"],
910
)
1011

11-
exports_files(["bazel-gazelle-PR1274.patch"])
12+
exports_files([
13+
"bazel-gazelle-PR1274.patch",
14+
"bazel-gazelle-revert-1152.patch",
15+
])
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
diff --git a/language/proto/generate.go b/language/proto/generate.go
2+
index afa0cbe..48bddc9 100644
3+
--- a/language/proto/generate.go
4+
+++ b/language/proto/generate.go
5+
@@ -235,12 +235,6 @@ func generateProto(pc *ProtoConfig, rel string, pkg *Package, shouldSetVisibilit
6+
r.SetPrivateAttr(PackageKey, *pkg)
7+
imports := make([]string, 0, len(pkg.Imports))
8+
for i := range pkg.Imports {
9+
- // If FileMode isn't enabled and the proto import is a self import
10+
- // (an import between the same package), skip it
11+
- if pc.Mode != FileMode && getPrefix(pc, path.Dir(i)) == getPrefix(pc, rel) {
12+
- delete(pkg.Imports, i)
13+
- continue
14+
- }
15+
imports = append(imports, i)
16+
}
17+
sort.Strings(imports)

0 commit comments

Comments
 (0)