Remove refs to goog.isObject, isArrayLike etc. that will be removed. (bazelbuild#645)

Author: gkdn

closure/testing/library/asserts.js

@@ -387,7 +387,7 @@ var assertThrows = goog.testing.asserts.assertThrows;
  */
 goog.testing.asserts.removeOperaStacktrace_ = function(e) {
   'use strict';
-  if (!goog.isObject(e)) return;
+  if (!e || typeof e != 'object') return;
   const stack = e['stacktrace'];
   const errorMsg = e['message'];
   if (typeof stack !== 'string' || typeof errorMsg !== 'string') {
@@ -513,7 +513,7 @@ goog.testing.asserts.assertRejects = function(a, opt_b) {
   var thenable = /** @type {!IThenable<*>} */ (nonCommentArg(1, 1, arguments));
   var comment = commentArg(1, arguments);
   _assert(
-      comment, goog.isObject(thenable) && typeof thenable.then === 'function',
+      comment, thenable && typeof thenable === 'object' && typeof thenable.then === 'function',
       () => 'Argument passed to assertRejects is not an IThenable');
 
   return thenable.then(
@@ -1484,7 +1484,17 @@ var assertSameElements = goog.testing.asserts.assertSameElements;
  */
 goog.testing.asserts.isArrayLikeOrIterable_ = function(obj) {
   'use strict';
-  return goog.isArrayLike(obj) || goog.testing.asserts.isIterable_(obj);
+  return goog.testing.asserts.isArrayLike_(obj) || goog.testing.asserts.isIterable_(obj);
+};
+
+/**
+ * @param {*} obj Object to test.
+ * @return {boolean} Whether given object is array-like.
+ * @private
+ */
+goog.testing.asserts.isArrayLike_ = function(obj) {
+  'use strict';
+  return Array.isArray(obj) || obj != null && typeof obj == 'object' && typeof obj.length == 'number'
 };
 
 /**

closure/testing/library/testcase.js

@@ -1537,14 +1537,9 @@ goog.testing.TestCase.prototype.addTestObj_ = function(obj, name, objChain) {
       var fullTestName = name + (testName && name ? '_' : '') + testName;
       if (typeof testProperty === 'function') {
         this.addNewTest(fullTestName, testProperty, obj, objChain);
-      } else if (goog.isObject(testProperty) && !Array.isArray(testProperty)) {
+      } else if (testProperty != null && typeof testProperty === 'object' && !Array.isArray(testProperty)) {
         // To prevent infinite loops.
         if (Array.prototype.indexOf.call(objChain, testProperty) < 0) {
-          if (!goog.isObject(testProperty)) {
-            throw new Error(
-                'Expected object but got %s: %s.',
-                [goog.typeOf(testProperty), testProperty]);
-          }
           var newObjChain = objChain.slice();
           newObjChain.push(testProperty);
           this.addTestObj_(testProperty, fullTestName, newObjChain);