Skip to content

Commit 37aa57e

Browse files
committed
Resolve maven dep issues
1 parent 06bcc2d commit 37aa57e

2 files changed

Lines changed: 18 additions & 4 deletions

File tree

MODULE.bazel

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,21 @@ platform_http_file(
141141
# -------------------------------------------------------------------
142142

143143
maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
144+
145+
# NOTE: even though we isolate OUR maven deps into a separate namespace, we
146+
# still need the ones from other contributing modules. That is why this
147+
# maven.install() declaration exists, and I am surprised bzlmod /
148+
# rules_jvm_external works this way.
149+
maven.install(
150+
name = "maven",
151+
known_contributing_modules = [
152+
"build_stack_rules_proto",
153+
"grpc-java",
154+
"io_bazel_rules_closure",
155+
"protobuf",
156+
"rules_web_testing_java",
157+
],
158+
)
144159
maven.install(
145160
name = "maven_rules_closure",
146161
artifacts = [
@@ -154,6 +169,7 @@ maven.install(
154169
"org.seleniumhq.selenium:selenium-api:4.27.0",
155170
"org.seleniumhq.selenium:selenium-support:4.27.0",
156171
],
172+
lock_file = "//:maven_rules_closure_install.json",
157173
)
158174
maven.artifact(
159175
name = "maven_rules_closure",

closure/webfiles/web_library.bzl

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
load(
1818
"//closure/private:defs.bzl",
1919
"WebFilesInfo",
20+
"collect_runfiles",
2021
"create_argfile",
2122
"difference",
2223
"extract_providers",
2324
"long_path",
2425
"unfurl",
25-
"collect_runfiles",
2626
)
2727

2828
def _web_library(ctx):
@@ -224,9 +224,7 @@ web_library = rule(
224224
cfg = "exec",
225225
),
226226
"server": attr.label(
227-
default = Label(
228-
"//java/io/bazel/rules/closure/webfiles/server:WebfilesServer",
229-
),
227+
default = Label("//java/io/bazel/rules/closure/webfiles/server:WebfilesServer"),
230228
executable = True,
231229
cfg = "exec",
232230
),

0 commit comments

Comments
 (0)