Log warning upon timeout waiting for pending channels to reach zero.

Author: drieseng

src/Renci.SshNet/ForwardedPortDynamic.NET.cs

@@ -264,7 +264,12 @@ partial void StopListener()
         partial void InternalStop(TimeSpan timeout)
         {
             _pendingChannelCountdown.Signal();
-            _pendingChannelCountdown.Wait(timeout);
+            if (!_pendingChannelCountdown.Wait(timeout))
+            {
+                // TODO: log as warning
+                DiagnosticAbstraction.Log("Timeout waiting for pending channels in dynamic forwarded port to close.");
+            }
+
         }
 
         partial void InternalDispose(bool disposing)

src/Renci.SshNet/ForwardedPortLocal.NET.cs

@@ -214,7 +214,11 @@ partial void StopListener()
         partial void InternalStop(TimeSpan timeout)
         {
             _pendingChannelCountdown.Signal();
-            _pendingChannelCountdown.Wait(timeout);
+            if (!_pendingChannelCountdown.Wait(timeout))
+            {
+                // TODO: log as warning
+                DiagnosticAbstraction.Log("Timeout waiting for pending channels in local forwarded port to close.");
+            }
         }
 
         partial void InternalDispose(bool disposing)

src/Renci.SshNet/ForwardedPortRemote.cs

@@ -201,7 +201,12 @@ protected override void StopPort(TimeSpan timeout)
 
             // wait for pending channels to close
             _pendingChannelCountdown.Signal();
-            _pendingChannelCountdown.Wait(timeout);
+            
+            if (!_pendingChannelCountdown.Wait(timeout))
+            {
+                // TODO: log as warning
+                DiagnosticAbstraction.Log("Timeout waiting for pending channels in remote forwarded port to close.");
+            }
 
             _status = ForwardedPortStatus.Stopped;
         }
@@ -244,10 +249,7 @@ private void Session_ChannelOpening(object sender, MessageEventArgs<ChannelOpenM
                             {
                                 RaiseRequestReceived(info.OriginatorAddress, info.OriginatorPort);
 
-                                using (
-                                    var channel =
-                                        Session.CreateChannelForwardedTcpip(channelOpenMessage.LocalChannelNumber,
-                                            channelOpenMessage.InitialWindowSize, channelOpenMessage.MaximumPacketSize))
+                                using (var channel = Session.CreateChannelForwardedTcpip(channelOpenMessage.LocalChannelNumber, channelOpenMessage.InitialWindowSize, channelOpenMessage.MaximumPacketSize))
                                 {
                                     channel.Exception += Channel_Exception;
                                     channel.Bind(new IPEndPoint(HostAddress, (int) Port), this);