Skip to content

Commit 3da9497

Browse files
kyleconroyclaude
andcommitted
Fix CRLF line ending comparison in explain tests
Normalize CRLF to LF when reading expected explain output files since some files may have Windows line endings. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent c34e702 commit 3da9497

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

parser/parser_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,8 @@ func TestParser(t *testing.T) {
270270
// Check explain output if explain file exists
271271
if expectedBytes, err := os.ReadFile(explainPath); err == nil {
272272
expected := strings.TrimSpace(string(expectedBytes))
273+
// Normalize CRLF to LF (some expected files may have Windows line endings)
274+
expected = strings.ReplaceAll(expected, "\r\n", "\n")
273275
// Strip version header comment (e.g., "-- Generated by ClickHouse X.X.X.X")
274276
if strings.HasPrefix(expected, "-- Generated by ClickHouse ") {
275277
if idx := strings.Index(expected, "\n"); idx != -1 {
Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1 @@
1-
{
2-
"explain_todo": {
3-
"stmt6": true
4-
}
5-
}
1+
{}

0 commit comments

Comments
 (0)