Skip to content

Commit 08fca57

Browse files
committed
Add Missing Serialization Support
Closed gh-19012 Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
1 parent acabacb commit 08fca57

9 files changed

Lines changed: 17 additions & 0 deletions

File tree

config/src/test/java/org/springframework/security/SerializationSamples.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@
211211
import org.springframework.security.web.webauthn.api.AuthenticationExtensionsClientOutputs;
212212
import org.springframework.security.web.webauthn.api.AuthenticatorAssertionResponse;
213213
import org.springframework.security.web.webauthn.api.AuthenticatorAttachment;
214+
import org.springframework.security.web.webauthn.api.AuthenticatorAttestationResponse;
214215
import org.springframework.security.web.webauthn.api.AuthenticatorTransport;
215216
import org.springframework.security.web.webauthn.api.Bytes;
216217
import org.springframework.security.web.webauthn.api.CredProtectAuthenticationExtensionsClientInput;
@@ -225,6 +226,7 @@
225226
import org.springframework.security.web.webauthn.api.PublicKeyCredentialType;
226227
import org.springframework.security.web.webauthn.api.PublicKeyCredentialUserEntity;
227228
import org.springframework.security.web.webauthn.api.TestAuthenticationAssertionResponses;
229+
import org.springframework.security.web.webauthn.api.TestAuthenticatorAttestationResponses;
228230
import org.springframework.security.web.webauthn.api.TestBytes;
229231
import org.springframework.security.web.webauthn.api.TestPublicKeyCredentialRequestOptions;
230232
import org.springframework.security.web.webauthn.api.TestPublicKeyCredentialUserEntities;
@@ -654,6 +656,8 @@ final class SerializationSamples {
654656
generatorByClassName.put(CredentialPropertiesOutput.class, (o) -> credentialOutput);
655657
generatorByClassName.put(ImmutableAuthenticationExtensionsClientOutputs.class, (o) -> outputs);
656658
generatorByClassName.put(AuthenticatorAssertionResponse.class, (r) -> response);
659+
generatorByClassName.put(AuthenticatorAttestationResponse.class,
660+
(r) -> TestAuthenticatorAttestationResponses.createAuthenticatorAttestationResponse().build());
657661
generatorByClassName.put(RelyingPartyAuthenticationRequest.class, (r) -> authRequest);
658662
generatorByClassName.put(PublicKeyCredential.class, (r) -> credential);
659663
generatorByClassName.put(WebAuthnAuthenticationRequestToken.class, (r) -> requestToken);

core/src/main/java/org/springframework/security/authorization/method/ExpressionAttributeAuthorizationDecision.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
* instead
2929
*/
3030
@Deprecated
31+
@SuppressWarnings("serial")
3132
public class ExpressionAttributeAuthorizationDecision extends AuthorizationDecision {
3233

3334
private final ExpressionAttribute expressionAttribute;

oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/OAuth2AuthorizationRequestRedirectFilter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,7 @@ protected void initExtractorMap() {
269269

270270
}
271271

272+
@SuppressWarnings("serial")
272273
private static final class OAuth2AuthorizationRequestException extends AuthenticationException {
273274

274275
OAuth2AuthorizationRequestException(Throwable cause) {

oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/DPoPProofJwtDecoderFactory.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ private static String computeSHA256(String value) throws Exception {
185185
return Base64.getUrlEncoder().withoutPadding().encodeToString(digest);
186186
}
187187

188+
@SuppressWarnings("serial")
188189
private static final class JtiCache extends LinkedHashMap<String, Long> {
189190

190191
private static final int MAX_SIZE = 1000;

saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/authentication/Saml2AuthenticationToken.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package org.springframework.security.saml2.provider.service.authentication;
1818

19+
import java.io.Serial;
1920
import java.util.Collections;
2021

2122
import org.springframework.security.authentication.AbstractAuthenticationToken;
@@ -33,6 +34,9 @@
3334
*/
3435
public class Saml2AuthenticationToken extends AbstractAuthenticationToken {
3536

37+
@Serial
38+
private static final long serialVersionUID = 5225098478444036532L;
39+
3640
private final RelyingPartyRegistration relyingPartyRegistration;
3741

3842
private final String saml2Response;

saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/registration/OpenSamlRelyingPartyRegistration.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
* </pre>
4343
*/
4444
@Deprecated
45+
@SuppressWarnings("serial")
4546
public final class OpenSamlRelyingPartyRegistration extends RelyingPartyRegistration {
4647

4748
OpenSamlRelyingPartyRegistration(RelyingPartyRegistration registration) {

web/src/main/java/org/springframework/security/web/access/expression/WebExpressionConfigAttribute.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
* {@link AuthorizationManager}.
3333
*/
3434
@Deprecated
35+
@SuppressWarnings("serial")
3536
class WebExpressionConfigAttribute implements ConfigAttribute, EvaluationContextPostProcessor<FilterInvocation> {
3637

3738
private final Expression authorizeExpression;

web/src/main/java/org/springframework/security/web/webauthn/api/AuthenticatorAttestationResponse.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package org.springframework.security.web.webauthn.api;
1818

19+
import java.io.Serial;
1920
import java.util.Arrays;
2021
import java.util.List;
2122

@@ -34,6 +35,9 @@
3435
*/
3536
public final class AuthenticatorAttestationResponse extends AuthenticatorResponse {
3637

38+
@Serial
39+
private static final long serialVersionUID = -1628559840895428945L;
40+
3741
private final Bytes attestationObject;
3842

3943
private final List<AuthenticatorTransport> transports;

0 commit comments

Comments
 (0)