Skip to content

Commit 057e518

Browse files
committed
Adjust Formatting
Issue gh-18805 Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
1 parent 178ca56 commit 057e518

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

web/src/main/java/org/springframework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandler.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,10 @@ protected String determineTargetUrl(HttpServletRequest request, HttpServletRespo
114114
}
115115

116116
String refererHeader = request.getHeader("Referer");
117-
if (this.useReferer && StringUtils.hasText(refererHeader)) {
117+
if (!StringUtils.hasText(refererHeader)) {
118+
return this.defaultTargetUrl;
119+
}
120+
if (this.useReferer) {
118121
trace("Using url %s from Referer header", refererHeader);
119122
return refererHeader;
120123
}

web/src/test/java/org/springframework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandlerTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ void setRedirectStrategyWhenGivenNullThenThrowsException() {
114114
assertThatIllegalArgumentException().isThrownBy(() -> this.handler.setRedirectStrategy(null));
115115
}
116116

117+
// gh-18805
117118
@Test
118119
void returnDefaultUrlIfUseRefererIsTrueAndRefererHeaderIsEmpty() {
119120
this.handler.setUseReferer(true);

0 commit comments

Comments
 (0)