Skip to content

Commit ad40666

Browse files
fix: Resolve debug URL uses flag id (#79)
fix: Resolve handling uses flag id
1 parent 1b34daf commit ad40666

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

confidence/confidence.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ def _setup_logger(self, logger: logging.Logger) -> None:
170170
def _handle_evaluation_result(
171171
self,
172172
result: ResolveResult,
173+
flag_id: str,
173174
flag_key: str,
174175
value_type: Type[FieldType],
175176
default_value: FieldType,
@@ -178,7 +179,7 @@ def _handle_evaluation_result(
178179
) -> FlagResolutionDetails[Any]:
179180
urlEncodedJsonContext = requests.utils.quote(json.dumps(context))
180181
self.logger.debug(
181-
f"See resolves for '{flag_key}' in Confidence: https://app.confidence.spotify.com/flags/resolver-test?client-key={self._client_secret}&flag=flags/{flag_key}&context={urlEncodedJsonContext}" # noqa: E501
182+
f"See resolves for '{flag_id}' in Confidence: https://app.confidence.spotify.com/flags/resolver-test?client-key={self._client_secret}&flag=flags/{flag_id}&context={urlEncodedJsonContext}" # noqa: E501
182183
)
183184

184185
if result.variant is None or len(str(result.value)) == 0:
@@ -218,7 +219,7 @@ def _evaluate(
218219
value_path = None
219220
result = self._resolve(FlagName(flag_id), context)
220221
return self._handle_evaluation_result(
221-
result, flag_key, value_type, default_value, value_path, context
222+
result, flag_id, flag_key, value_type, default_value, value_path, context
222223
)
223224

224225
async def _evaluate_async(
@@ -235,7 +236,7 @@ async def _evaluate_async(
235236
value_path = None
236237
result = await self._resolve_async(FlagName(flag_id), context)
237238
return self._handle_evaluation_result(
238-
result, flag_key, value_type, default_value, value_path, context
239+
result, flag_id, flag_key, value_type, default_value, value_path, context
239240
)
240241

241242
# type-arg: ignore

0 commit comments

Comments
 (0)