refactor(Split require): Fix issue where redis isn't required. Auto require all necessary files. (#466)

Author: tomciopp

lib/split.rb

@@ -1,23 +1,10 @@
 # frozen_string_literal: true
-%w[algorithms
-   alternative
-   configuration
-   exceptions
-   experiment
-   experiment_catalog
-   extensions
-   goals_collection
-   helper
-   metric
-   persistence
-   encapsulated_helper
-   redis_interface
-   trial
-   user
-   version
-   zscore].each do |f|
-  require "split/#{f}"
-end
+require 'redis'
+
+# Auto require all files except for those that include 'dashboard' or 'engine'
+Dir["#{File.expand_path(File.dirname(__FILE__))}/**/*.rb"].reject do |file|
+  file["dashboard"] || file["engine"]
+end.each { |file| require file }
 
 require 'split/engine' if defined?(Rails)
 

lib/split/algorithms.rb

@@ -1,17 +1,11 @@
 # frozen_string_literal: true
-require 'split/zscore'
-
-# TODO - take out require and implement using file paths?
-
 module Split
   class Alternative
     attr_accessor :name
     attr_accessor :experiment_name
     attr_accessor :weight
     attr_accessor :recorded_info
 
-    include Zscore
-
     def initialize(name, experiment_name)
       @experiment_name = experiment_name
       if Hash === name

lib/split/alternative.rb

@@ -1,4 +1,6 @@
 # frozen_string_literal: true
+require "split/helper"
+
 # Split's helper exposes all kinds of methods we don't want to
 # mix into our model classes.
 #

lib/split/encapsulated_helper.rb

@@ -1,8 +1,4 @@
 # frozen_string_literal: true
-%w[session_adapter cookie_adapter redis_adapter dual_adapter].each do |f|
-  require "split/persistence/#{f}"
-end
-
 module Split
   module Persistence
     ADAPTERS = {

lib/split/extensions.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module Split
-  module Zscore
+  class Zscore
 
     include Math
 

lib/split/persistence.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 require 'spec_helper'
-require 'split/experiment'
-require 'split/algorithms'
 require 'time'
 
 describe Split::Experiment do