Skip to content

Commit ce8cf68

Browse files
[issue-426] change external_references to singular
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
1 parent b200026 commit ce8cf68

34 files changed

Lines changed: 72 additions & 72 deletions

src/spdx_tools/spdx3/bump_from_spdx2/package.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ def bump_package(
7575
"and missing definition of license profile",
7676
)
7777

78-
external_references = []
79-
external_identifiers = []
78+
external_reference = []
79+
external_identifier = []
8080
purl_refs = [
8181
external_ref for external_ref in spdx2_package.external_references if external_ref.reference_type == "purl"
8282
]
@@ -89,9 +89,9 @@ def bump_package(
8989
continue
9090
id_or_ref = bump_external_package_ref(spdx2_external_ref)
9191
if isinstance(id_or_ref, ExternalReference):
92-
external_references.append(id_or_ref)
92+
external_reference.append(id_or_ref)
9393
elif isinstance(id_or_ref, ExternalIdentifier):
94-
external_identifiers.append(id_or_ref)
94+
external_identifier.append(id_or_ref)
9595

9696
package_purpose = SoftwarePurpose[spdx2_package.primary_package_purpose.name]
9797

@@ -104,8 +104,8 @@ def bump_package(
104104
description=spdx2_package.description,
105105
comment=spdx2_package.comment,
106106
verified_using=integrity_methods,
107-
external_references=external_references,
108-
external_identifier=external_identifiers,
107+
external_reference=external_reference,
108+
external_identifier=external_identifier,
109109
originated_by=originated_by_spdx_id,
110110
supplied_by=supplied_by_spdx_id,
111111
built_time=spdx2_package.built_date,

src/spdx_tools/spdx3/model/agent.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ def __init__(
1919
description: Optional[str] = None,
2020
comment: Optional[str] = None,
2121
verified_using: List[IntegrityMethod] = None,
22-
external_references: List[ExternalReference] = None,
22+
external_reference: List[ExternalReference] = None,
2323
external_identifier: List[ExternalIdentifier] = None,
2424
extension: Optional[str] = None,
2525
):
2626
verified_using = [] if verified_using is None else verified_using
27-
external_references = [] if external_references is None else external_references
27+
external_reference = [] if external_reference is None else external_reference
2828
external_identifier = [] if external_identifier is None else external_identifier
2929
check_types_and_set_values(self, locals())

src/spdx_tools/spdx3/model/ai/ai_package.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def __init__(
5353
description: Optional[str] = None,
5454
comment: Optional[str] = None,
5555
verified_using: List[IntegrityMethod] = None,
56-
external_references: List[ExternalReference] = None,
56+
external_reference: List[ExternalReference] = None,
5757
external_identifier: List[ExternalIdentifier] = None,
5858
extension: Optional[str] = None,
5959
originated_by: List[str] = None,
@@ -86,7 +86,7 @@ def __init__(
8686
safety_risk_assessment: Optional[SafetyRiskAssessmentType] = None,
8787
):
8888
verified_using = [] if verified_using is None else verified_using
89-
external_references = [] if external_references is None else external_references
89+
external_reference = [] if external_reference is None else external_reference
9090
external_identifier = [] if external_identifier is None else external_identifier
9191
originated_by = [] if originated_by is None else originated_by
9292
additional_purpose = [] if additional_purpose is None else additional_purpose

src/spdx_tools/spdx3/model/annotation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ def __init__(
3434
description: Optional[str] = None,
3535
comment: Optional[str] = None,
3636
verified_using: List[IntegrityMethod] = None,
37-
external_references: List[ExternalReference] = None,
37+
external_reference: List[ExternalReference] = None,
3838
external_identifier: List[ExternalIdentifier] = None,
3939
extension: Optional[str] = None,
4040
content_type: List[str] = None,
4141
statement: Optional[str] = None,
4242
):
4343
verified_using = [] if verified_using is None else verified_using
44-
external_references = [] if external_references is None else external_references
44+
external_reference = [] if external_reference is None else external_reference
4545
external_identifier = [] if external_identifier is None else external_identifier
4646
content_type = [] if content_type is None else content_type
4747
check_types_and_set_values(self, locals())

src/spdx_tools/spdx3/model/bom.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@ def __init__(
3232
description: Optional[str] = None,
3333
comment: Optional[str] = None,
3434
verified_using: List[IntegrityMethod] = None,
35-
external_references: List[ExternalReference] = None,
35+
external_reference: List[ExternalReference] = None,
3636
external_identifier: List[ExternalIdentifier] = None,
3737
extension: Optional[str] = None,
3838
namespaces: List[NamespaceMap] = None,
3939
imports: List[ExternalMap] = None,
4040
context: Optional[str] = None,
4141
):
4242
verified_using = [] if verified_using is None else verified_using
43-
external_references = [] if external_references is None else external_references
43+
external_reference = [] if external_reference is None else external_reference
4444
external_identifier = [] if external_identifier is None else external_identifier
4545
namespaces = [] if namespaces is None else namespaces
4646
imports = [] if imports is None else imports

src/spdx_tools/spdx3/model/build/build.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def __init__(
3333
description: Optional[str] = None,
3434
comment: Optional[str] = None,
3535
verified_using: List[IntegrityMethod] = None,
36-
external_references: List[ExternalReference] = None,
36+
external_reference: List[ExternalReference] = None,
3737
external_identifier: List[ExternalIdentifier] = None,
3838
extension: Optional[str] = None,
3939
build_id: Optional[str] = None,
@@ -46,7 +46,7 @@ def __init__(
4646
environment: Dict[str, str] = None,
4747
):
4848
verified_using = [] if verified_using is None else verified_using
49-
external_references = [] if external_references is None else external_references
49+
external_reference = [] if external_reference is None else external_reference
5050
external_identifier = [] if external_identifier is None else external_identifier
5151
config_source_entrypoint = [] if config_source_entrypoint is None else config_source_entrypoint
5252
config_source_uri = [] if config_source_uri is None else config_source_uri

src/spdx_tools/spdx3/model/bundle.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ def __init__(
3131
description: Optional[str] = None,
3232
comment: Optional[str] = None,
3333
verified_using: List[IntegrityMethod] = None,
34-
external_references: List[ExternalReference] = None,
34+
external_reference: List[ExternalReference] = None,
3535
external_identifier: List[ExternalIdentifier] = None,
3636
extension: Optional[str] = None,
3737
namespaces: List[NamespaceMap] = None,
3838
imports: List[ExternalMap] = None,
3939
context: Optional[str] = None,
4040
):
4141
verified_using = [] if verified_using is None else verified_using
42-
external_references = [] if external_references is None else external_references
42+
external_reference = [] if external_reference is None else external_reference
4343
external_identifier = [] if external_identifier is None else external_identifier
4444
namespaces = [] if namespaces is None else namespaces
4545
imports = [] if imports is None else imports

src/spdx_tools/spdx3/model/dataset/dataset.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def __init__(
7777
description: Optional[str] = None,
7878
comment: Optional[str] = None,
7979
verified_using: List[IntegrityMethod] = None,
80-
external_references: List[ExternalReference] = None,
80+
external_reference: List[ExternalReference] = None,
8181
external_identifier: List[ExternalIdentifier] = None,
8282
extension: Optional[str] = None,
8383
supplied_by: List[str] = None,
@@ -107,7 +107,7 @@ def __init__(
107107
dataset_availability: Optional[DatasetAvailabilityType] = None,
108108
):
109109
verified_using = [] if verified_using is None else verified_using
110-
external_references = [] if external_references is None else external_references
110+
external_reference = [] if external_reference is None else external_reference
111111
external_identifier = [] if external_identifier is None else external_identifier
112112
originated_by = [] if originated_by is None else originated_by
113113
additional_purpose = [] if additional_purpose is None else additional_purpose

src/spdx_tools/spdx3/model/element.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class Element(ABC):
1919
description: Optional[str] = None
2020
comment: Optional[str] = None
2121
verified_using: List[IntegrityMethod] = field(default_factory=list)
22-
external_references: List[ExternalReference] = field(default_factory=list)
22+
external_reference: List[ExternalReference] = field(default_factory=list)
2323
external_identifier: List[ExternalIdentifier] = field(default_factory=list)
2424
extension: Optional[str] = None # placeholder for extension
2525

src/spdx_tools/spdx3/model/lifecycle_scoped_relationship.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def __init__(
4444
description: Optional[str] = None,
4545
comment: Optional[str] = None,
4646
verified_using: List[IntegrityMethod] = None,
47-
external_references: List[ExternalReference] = None,
47+
external_reference: List[ExternalReference] = None,
4848
external_identifier: List[ExternalIdentifier] = None,
4949
extension: Optional[str] = None,
5050
completeness: Optional[RelationshipCompleteness] = None,
@@ -54,6 +54,6 @@ def __init__(
5454
):
5555
to = [] if to is None else to
5656
verified_using = [] if verified_using is None else verified_using
57-
external_references = [] if external_references is None else external_references
57+
external_reference = [] if external_reference is None else external_reference
5858
external_identifier = [] if external_identifier is None else external_identifier
5959
check_types_and_set_values(self, locals())

0 commit comments

Comments
 (0)