[issue-426] update model: make created_using optional

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>

Author: armintaenzertng

src/spdx_tools/spdx3/bump_from_spdx2/creation_info.py

@@ -36,7 +36,6 @@ def bump_creation_info(spdx2_creation_info: Spdx2_CreationInfo, payload: Payload
         spec_version=Version("3.0.0"),
         created=spdx2_creation_info.created,
         created_by=[],
-        created_using=[],
         profile=[ProfileIdentifier.CORE, ProfileIdentifier.SOFTWARE, ProfileIdentifier.LICENSING],
         data_license="https://spdx.org/licenses/" + spdx2_creation_info.data_license,
     )

src/spdx_tools/spdx3/model/creation_info.py

@@ -1,6 +1,7 @@
 # SPDX-FileCopyrightText: 2023 spdx contributors
 #
 # SPDX-License-Identifier: Apache-2.0
+from dataclasses import field
 from datetime import datetime
 
 from beartype.typing import List, Optional
@@ -16,19 +17,20 @@ class CreationInfo:
     spec_version: Version
     created: datetime
     created_by: List[str]  # SPDXID of Agents
-    created_using: List[str]  # SPDXID of Tools
     profile: List[ProfileIdentifier]
-    data_license: str
+    data_license: Optional[str] = "CC0-1.0"
+    created_using: List[str] = field(default_factory=list)  # SPDXID of Tools
     comment: Optional[str] = None
 
     def __init__(
         self,
         spec_version: Version,
         created: datetime,
         created_by: List[str],
-        created_using: List[str],
         profile: List[ProfileIdentifier],
-        data_license: str = "CC0",
+        data_license: Optional[str] = "CC0-1.0",
+        created_using: List[str] = None,
         comment: Optional[str] = None,
     ):
+        created_using = [] if created_using is None else created_using
         check_types_and_set_values(self, locals())

tests/spdx3/bump/test_actor_bump.py

@@ -37,7 +37,7 @@
 def test_bump_actor(actor_type, actor_name, actor_mail, element_type, new_spdx_id):
     payload = Payload()
     document_namespace = "https://doc.namespace"
-    creation_info = CreationInfo(Version("3.0.0"), datetime(2022, 1, 1), ["Creator"], [], [ProfileIdentifier.CORE])
+    creation_info = CreationInfo(Version("3.0.0"), datetime(2022, 1, 1), ["Creator"], [ProfileIdentifier.CORE])
     actor = Actor(actor_type, actor_name, actor_mail)
 
     agent_or_tool_id = bump_actor(actor, payload, document_namespace, creation_info)
@@ -54,8 +54,8 @@ def test_bump_actor(actor_type, actor_name, actor_mail, element_type, new_spdx_i
 
 
 def test_bump_actor_that_already_exists():
-    creation_info_old = CreationInfo(Version("3.0.0"), datetime(2022, 1, 1), ["Creator"], [], [ProfileIdentifier.CORE])
-    creation_info_new = CreationInfo(Version("3.0.0"), datetime(2023, 2, 2), ["Creator"], [], [ProfileIdentifier.CORE])
+    creation_info_old = CreationInfo(Version("3.0.0"), datetime(2022, 1, 1), ["Creator"], [ProfileIdentifier.CORE])
+    creation_info_new = CreationInfo(Version("3.0.0"), datetime(2023, 2, 2), ["Creator"], [ProfileIdentifier.CORE])
 
     name = "some name"
     document_namespace = "https://doc.namespace"

tests/spdx3/fixtures.py

@@ -101,9 +101,9 @@ def creation_info_fixture(
         spec_version=spec_version,
         created=created,
         created_by=created_by,
-        created_using=created_using,
         profile=profile,
         data_license=data_license,
+        created_using=created_using,
         comment=comment,
     )
 

tests/spdx3/model/test_creation_info.py

@@ -32,7 +32,7 @@ def test_correct_initialization():
 
 def test_invalid_initialization():
     with pytest.raises(TypeError) as err:
-        CreationInfo("2.3", "2012-01-01", [], [], "core", 3, [])
+        CreationInfo("2.3", "2012-01-01", [], "core", 3, [], [])
 
     assert len(err.value.args[0]) == 5
     for error in err.value.args[0]:
@@ -44,6 +44,6 @@ def test_incomplete_initialization():
         CreationInfo("2.3")
 
     assert (
-        "__init__() missing 4 required positional arguments: 'created', 'created_by', 'created_using', and 'profile'"
+        "__init__() missing 3 required positional arguments: 'created', 'created_by', and 'profile'"
         in err.value.args[0]
     )