Skip to content

Commit 3801f04

Browse files
bactgoneall
authored andcommitted
Fix isSingleTokenString return
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
1 parent 84d5635 commit 3801f04

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

src/main/java/org/spdx/utility/compare/LicenseCompareHelper.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import java.util.regex.Matcher;
2828
import java.util.regex.Pattern;
2929
import java.util.Collection;
30+
import javax.annotation.Nullable;
3031

3132
import org.slf4j.Logger;
3233
import org.slf4j.LoggerFactory;
@@ -206,7 +207,7 @@ public static String locateOriginalText(String fullLicenseText, int startToken,
206207
* or {@code null} if none is found.
207208
*/
208209
public static @Nullable String getFirstLicenseToken(@Nullable String text) {
209-
if (text == null) {
210+
if (text == null || text.isEmpty()) {
210211
return null;
211212
}
212213
String textToTokenize = LicenseTextHelper.normalizeText(LicenseTextHelper.replaceMultWord(LicenseTextHelper.replaceSpaceComma(
@@ -233,7 +234,7 @@ public static String locateOriginalText(String fullLicenseText, int startToken,
233234
* {@code false} otherwise.
234235
*/
235236
public static boolean isSingleTokenString(@Nullable String text) {
236-
if (text == null) {
237+
if (text == null || text.isEmpty()) {
237238
return false;
238239
}
239240
if (text.contains("\n")) {
@@ -250,7 +251,7 @@ public static boolean isSingleTokenString(@Nullable String text) {
250251
}
251252
}
252253
}
253-
return true;
254+
return found;
254255
}
255256

256257
/**

src/test/java/org/spdx/utility/compare/LicenseCompareHelperTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -542,13 +542,18 @@ public void testLicenseEqualsNoneLicense() throws InvalidSPDXAnalysisException,
542542
}
543543

544544
public void testisSingleTokenString() {
545-
assertTrue(LicenseCompareHelper.isSingleTokenString(""));
545+
assertTrue(LicenseCompareHelper.isSingleTokenString("token"));
546546
assertTrue(LicenseCompareHelper.isSingleTokenString(" token "));
547+
assertTrue(LicenseCompareHelper.isSingleTokenString(" \n token "));
547548
assertTrue(LicenseCompareHelper.isSingleTokenString("'"));
548549
assertTrue(LicenseCompareHelper.isSingleTokenString(" '"));
549550
assertTrue(LicenseCompareHelper.isSingleTokenString("' "));
550551
assertFalse(LicenseCompareHelper.isSingleTokenString("a and"));
551552
assertFalse(LicenseCompareHelper.isSingleTokenString("a\nand"));
553+
assertFalse(LicenseCompareHelper.isSingleTokenString("a and "));
554+
assertFalse(LicenseCompareHelper.isSingleTokenString(" a and"));
555+
assertFalse(LicenseCompareHelper.isSingleTokenString("\n"));
556+
assertFalse(LicenseCompareHelper.isSingleTokenString(""));
552557
assertFalse(LicenseCompareHelper.isSingleTokenString(null));
553558
}
554559

0 commit comments

Comments
 (0)