Skip to content

Commit a99b264

Browse files
authored
Run CI tests on fully native non-portable builds (#608)
See: #606 Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
1 parent 3efe295 commit a99b264

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

.github/workflows/test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ jobs:
9797
run: >
9898
cmake -S . -B ./build
9999
-DCMAKE_BUILD_TYPE:STRING=Release
100-
-DJSONSCHEMA_PORTABLE:BOOL=ON
101100
-DJSONSCHEMA_TESTS:BOOL=ON
102101
-DJSONSCHEMA_TESTS_CI:BOOL=ON
103102
-DJSONSCHEMA_DEVELOPMENT:BOOL=ON

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ option(JSONSCHEMA_CONTINUOUS "Perform a continuous JSON Schema CLI release" ON)
1212
option(JSONSCHEMA_PORTABLE "Build a portable JSON Schema CLI binary to increase platform support" OFF)
1313

1414
find_package(Core REQUIRED)
15-
if(NOT JSONSCHEMA_PORTABLE)
15+
if(NOT JSONSCHEMA_PORTABLE AND NOT MSVC)
1616
message(STATUS "Building an optimised but less portable binary (JSONSCHEMA_PORTABLE)")
1717
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -march=native")
1818
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -mtune=native")

0 commit comments

Comments
 (0)