Skip to content

Commit 04e5d6f

Browse files
authored
Fix setter callback form type, remove unneeded as T. (#682)
1 parent 457dca7 commit 04e5d6f

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

packages/solid/src/reactive/signal.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import type { JSX } from "../jsx";
55

66
export type Accessor<T> = () => T;
77
export type Setter<T> = undefined extends T
8-
? <U extends T>(v?: (U extends Function ? never : U) | ((prev?: U) => U)) => U
9-
: <U extends T>(v: (U extends Function ? never : U) | ((prev: U) => U)) => U;
8+
? <U extends T>(v?: (U extends Function ? never : U) | ((prev?: T) => U)) => U
9+
: <U extends T>(v: (U extends Function ? never : U) | ((prev: T) => U)) => U;
1010
export const equalFn = <T>(a: T, b: T) => a === b;
1111
export const $PROXY = Symbol("solid-proxy");
1212
const signalOptions = { equals: equalFn };
@@ -166,8 +166,8 @@ export function createSignal<T>(
166166
((value: T extends Function ? never : T | ((p?: T) => T)) => {
167167
if (typeof value === "function") {
168168
if (Transition && Transition.running && Transition.sources.has(s))
169-
value = value(s.pending !== NOTPENDING ? (s.pending as T) : s.tValue);
170-
else value = value(s.pending !== NOTPENDING ? (s.pending as T) : s.value);
169+
value = value(s.pending !== NOTPENDING ? s.pending : s.tValue);
170+
else value = value(s.pending !== NOTPENDING ? s.pending : s.value);
171171
}
172172
return writeSignal(s, value);
173173
}) as Setter<T>

0 commit comments

Comments
 (0)