Skip to content

Commit 932593d

Browse files
committed
remove direct async local storage references
1 parent 283df1b commit 932593d

2 files changed

Lines changed: 4 additions & 17 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@solidjs/meta",
33
"description": "Write meta tags to the document head",
4-
"version": "0.29.1",
4+
"version": "0.29.2",
55
"author": "Ryan Carniato",
66
"license": "MIT",
77
"repository": {

src/index.tsx

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
sharedConfig,
1010
useContext
1111
} from "solid-js";
12-
import { isServer, spread, escape, useAssets, getRequestEvent, ssr } from "solid-js/web";
12+
import { isServer, spread, escape, useAssets, ssr } from "solid-js/web";
1313

1414
export const MetaContext = createContext<MetaContextType>();
1515

@@ -19,7 +19,6 @@ declare module "solid-js/web" {
1919
}
2020
}
2121

22-
2322
interface TagDescription {
2423
tag: string;
2524
props: Record<string, unknown>;
@@ -202,11 +201,8 @@ function initServerProvider() {
202201
}
203202

204203
export const MetaProvider: ParentComponent = props => {
205-
let e;
206-
const actions: MetaContextType | undefined = !isServer
204+
const actions = !isServer
207205
? initClientProvider()
208-
: (e = getRequestEvent())
209-
? e.solidMeta || (e.solidMeta = initServerProvider())
210206
: initServerProvider();
211207
return <MetaContext.Provider value={actions!}>{props.children}</MetaContext.Provider>;
212208
};
@@ -230,16 +226,7 @@ const MetaTag = (
230226
};
231227

232228
export function useHead(tagDesc: TagDescription) {
233-
let c: MetaContextType | undefined;
234-
if (isServer) {
235-
const event = getRequestEvent();
236-
c = event && event.solidMeta;
237-
// TODO: Consider if we want to support tags above MetaProvider
238-
// if (event) {
239-
// c = event.solidMeta || (event.solidMeta = initServerProvider());
240-
// }
241-
}
242-
c = c || useContext(MetaContext);
229+
const c = useContext(MetaContext);
243230
if (!c) throw new Error("<MetaProvider /> should be in the tree");
244231

245232
createRenderEffect(() => {

0 commit comments

Comments
 (0)