upgrade: filesystem package upgrade for Solid 2.0 #904
Conversation
🦋 Changeset detectedLatest commit: ac37352 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/filesystem/package.json`:
- Around line 62-70: The package currently imports `@solidjs/web` at runtime in
packages/filesystem/src/adapter-node.ts and
packages/filesystem/src/adapter-web.ts but only lists it in devDependencies;
update packages/filesystem/package.json to add "`@solidjs/web`" to
"peerDependencies" (matching the version used in devDependencies) so consumers
install the runtime dependency; ensure the version string matches the existing
"`@solidjs/web`" entry (e.g., "2.0.0-beta.13") and keep or remove the
devDependency entry as appropriate for local development.
In `@packages/filesystem/src/reactive.ts`:
- Around line 269-274: The readdir watcher cache is being corrupted by appending
the full path instead of the directory entry name; in the block using
readdirMap.get(getParentDir(path)) (variables: readdirMap, getParentDir,
readdirEntry, mutate, path) compute the entry name as the basename/last segment
of path (e.g. const name = path.split('/').pop() or use an existing basename
helper) and push that name into the cached items (mutate([...items, name] as
DirEntries)) rather than the full path so the readdir cache retains directory
entry names.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 614a40ea-4149-41e5-be99-11f6d0477b00
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (7)
.changeset/filesystem-solid2-migration.mdpackages/filesystem/package.jsonpackages/filesystem/src/adapter-node.tspackages/filesystem/src/adapter-web.tspackages/filesystem/src/reactive.tspackages/filesystem/src/tools.tspackages/filesystem/test/index.test.ts
Mostly minor changes and remove of createResource
Summary by CodeRabbit
@solidjs/webas peer dependencies