Skip to content

upgrade: idle package upgrade for Solid 2.0#888

Open
davedbase wants to merge 3 commits into
solidjs-community:nextfrom
davedbase:update/v2/idle
Open

upgrade: idle package upgrade for Solid 2.0#888
davedbase wants to merge 3 commits into
solidjs-community:nextfrom
davedbase:update/v2/idle

Conversation

@davedbase
Copy link
Copy Markdown
Member

@davedbase davedbase commented May 10, 2026

src/createIdleTimer.ts`

  • isServer import moved to @solidjs/web
  • onMountonSettled
  • batch() calls removed (replaced with sequential signal writes)
  • Both signals now use INTERNAL_OPTIONS (ownedWrite: true)
  • Server return uses noop from utils

test/index.test.ts

  • Added flush import from solid-js
  • Added flush() after every signal-writing operation: after onSettled fires (via the existing call), after each vi.advanceTimersByTime() that triggers timer callbacks, after timer.start(), timer.reset(), timer.stop(), timer.triggerIdle(), and after DOM event dispatches that invoke handleEvent

test/server.test.ts — new SSR safety test

README.md — fixed default events list (removed stale "mousewheel", only "wheel" is in the actual defaults)

.changeset/idle-solid2-migration.md — major version bump changeset

Summary by CodeRabbit

  • Bug Fixes

    • Fixed duplicate "wheel" event in the idle timer's default monitored events configuration, improving consistency.
  • Tests

    • Added server-side behavior tests to verify idle timer functionality works correctly in server-rendered environments.
  • Updates

    • Now requires Solid.js v2.0-beta.10 for compatibility with the latest framework version.

Review Change Stack

@davedbase davedbase added this to the Solid 2.0 Migration milestone May 10, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 10, 2026

🦋 Changeset detected

Latest commit: f8eb78d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/idle Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davedbase davedbase marked this pull request as ready for review May 23, 2026 16:05
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2d62a8e0-1ed9-4ee0-9498-31c32e6572f7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant