Ticket #910 : Check attribute uniqueness

Author: habarthierry-hue

src/Scim/SimpleIdServer.Scim/Commands/Handlers/AddRepresentationCommandHandler.cs

@@ -70,7 +70,7 @@ public async virtual Task<GenericResult<SCIMRepresentation>> Handle(AddRepresent
             scimRepresentation.RealmName = addRepresentationCommand.Realm;
             scimRepresentation.SetResourceType(addRepresentationCommand.ResourceType);
             foreach (var attr in scimRepresentation.FlatAttributes) attr.RepresentationId = scimRepresentation.Id;
-            await _representationHelper.CheckUniqueness(scimRepresentation.FlatAttributes);
+            await _representationHelper.CheckUniqueness(addRepresentationCommand.Realm, scimRepresentation.FlatAttributes);
             var patchOperations = scimRepresentation.FlatAttributes.Select(a => new SCIMPatchResult
             {
                 Attr = a,

src/Scim/SimpleIdServer.Scim/Commands/Handlers/ReplaceRepresentationCommandHandler.cs

@@ -58,7 +58,7 @@ public async virtual Task<GenericResult<ReplaceRepresentationResult>> Handle(Rep
             var patchOperations = patchResult.Patches.Where(p => p.Attr != null).ToList();
             var displayNameDifferent = existingRepresentation.DisplayName != oldDisplayName;
             var modifiedAttributes = patchOperations.Where(p => p.Operation != SCIMPatchOperations.REMOVE && p.Attr != null && !p.Attr.IsLeaf() && p.Attr.SchemaAttribute.MultiValued == false).Select(p => p.Attr);
-            await _representationHelper.CheckUniqueness(modifiedAttributes);
+            await _representationHelper.CheckUniqueness(replaceRepresentationCommand.Realm, modifiedAttributes);
             _representationHelper.CheckMutability(patchOperations);
             var references = await _representationReferenceSync.Sync(existingRepresentation.ResourceType, existingRepresentation, patchOperations, replaceRepresentationCommand.Location, schema, displayNameDifferent);
             await using (var transaction = await _scimRepresentationCommandRepository.StartTransaction().ConfigureAwait(false))

src/Scim/SimpleIdServer.Scim/Helpers/RepresentationHelper.cs

@@ -23,7 +23,7 @@ namespace SimpleIdServer.Scim.Helpers
     public interface IRepresentationHelper
     {
         Task<SCIMRepresentationPatchResult> Apply(SCIMRepresentation representation, IEnumerable<PatchOperationParameter> patchLst, IEnumerable<SCIMAttributeMapping> attributeMappings, bool ignoreUnsupportedCanonicalValues, CancellationToken cancellationToken);
-        Task CheckUniqueness(IEnumerable<SCIMRepresentationAttribute> attributes);
+        Task CheckUniqueness(string realm, IEnumerable<SCIMRepresentationAttribute> attributes);
         void CheckMutability(List<SCIMPatchResult> patchOperations);
         SCIMRepresentation ExtractSCIMRepresentationFromJSON(JsonObject json, string externalId, SCIMSchema mainSchema, ICollection<SCIMSchema> extensionSchemas, IEnumerable<SCIMAttributeMapping> attributeMappings);
     }
@@ -547,15 +547,15 @@ private static List<SCIMRepresentationAttribute> FilterDuplicate(IEnumerable<SCI
 
         #region Check uniqueness
 
-        public async Task CheckUniqueness(IEnumerable<SCIMRepresentationAttribute> attributes)
+        public async Task CheckUniqueness(string realm, IEnumerable<SCIMRepresentationAttribute> attributes)
         {
             var uniqueServerAttributeIds = attributes.Where(a => a.SchemaAttribute.Uniqueness == SCIMSchemaAttributeUniqueness.SERVER);
             var uniqueGlobalAttributes = attributes.Where(a => a.SchemaAttribute.Uniqueness == SCIMSchemaAttributeUniqueness.GLOBAL);
-            await CheckSCIMRepresentationExistsForGivenUniqueAttributes(uniqueServerAttributeIds);
-            await CheckSCIMRepresentationExistsForGivenUniqueAttributes(uniqueGlobalAttributes);
+            await CheckSCIMRepresentationExistsForGivenUniqueAttributes(realm, uniqueServerAttributeIds);
+            await CheckSCIMRepresentationExistsForGivenUniqueAttributes(realm, uniqueGlobalAttributes);
         }
 
-        private async Task CheckSCIMRepresentationExistsForGivenUniqueAttributes(IEnumerable<SCIMRepresentationAttribute> attributes)
+        private async Task CheckSCIMRepresentationExistsForGivenUniqueAttributes(string realm, IEnumerable<SCIMRepresentationAttribute> attributes)
         {
             foreach (var attribute in attributes)
             {
@@ -567,11 +567,21 @@ private async Task CheckSCIMRepresentationExistsForGivenUniqueAttributes(IEnumer
                         break;
                     case SCIMSchemaAttributeTypes.INTEGER:
                         if (attribute.ValueInteger != null)
+                        {
                             records = await _scimRepresentationCommandRepository.FindAttributesByValue(attribute.SchemaAttribute.Id, attribute.ValueInteger.Value);
+                        }
                         break;
                 }
 
-                if (records != null && records.Any())
+                var isUnique = records != null && records.Any();
+                if(!string.IsNullOrWhiteSpace(realm))
+                {
+                    var representations = await _scimRepresentationCommandRepository.FindRepresentations(records.Select(r => r.RepresentationId).Distinct().ToList());
+                    var filteredRepresentations = representations.Where(r => r.RealmName == realm);
+                    isUnique = filteredRepresentations != null && filteredRepresentations.Any();
+                }
+
+                if (isUnique)
                 {
                     throw new SCIMUniquenessAttributeException(string.Format(Global.AttributeMustBeUnique, attribute.SchemaAttribute.Name));
                 }