Ticket #7 : support processtask

Author: Thierry Habart

Doc.docx

@@ -1,15 +1,18 @@
 using CaseManagement.CMMN.CaseInstance.CommandHandlers;
 using CaseManagement.CMMN.CaseInstance.Commands;
+using CaseManagement.CMMN.CaseInstance.Exceptions;
 using CaseManagement.CMMN.Domains;
 using CaseManagement.CMMN.Extensions;
 using CaseManagement.Workflow.Domains;
+using CaseManagement.Workflow.Domains.Process.Exceptions;
 using CaseManagement.Workflow.Persistence;
 using CaseManagement.Workflow.Persistence.Parameters;
 using CaseManagement.Workflow.Persistence.Responses;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;
 using Newtonsoft.Json.Linq;
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Net;
 using System.Threading.Tasks;
@@ -59,10 +62,38 @@ public async Task<IActionResult> Launch(string id)
         }
 
         [HttpPost("{id}/confirm/{elt}")]
-        public async Task<IActionResult> ConfirmForm(string id, string elt, [FromBody] ConfirmFormCommand confirmForm)
+        public async Task<IActionResult> ConfirmForm(string id, string elt, [FromBody] JObject jObj)
         {
-            await _confirmFormCommandHandler.Handle(new ConfirmFormCommand { CaseInstanceId = id, CaseElementInstanceId = elt });
-            return new OkResult();
+            try
+            {
+                await _confirmFormCommandHandler.Handle(new ConfirmFormCommand { CaseInstanceId = id, CaseElementInstanceId = elt, Content = jObj });
+                return new OkResult();
+            }
+            catch(UnknownCaseInstanceException)
+            {
+                return ToError(new Dictionary<string, string>
+                {
+                    { "bad_request", "case instance doesn't exist" }
+                }, HttpStatusCode.NotFound, Request);
+            }
+            catch (UnknownCaseInstanceElementException)
+            {
+                return ToError(new Dictionary<string, string>
+                {
+                    { "bad_request", "case instance element doesn't exist" }
+                }, HttpStatusCode.NotFound, Request);
+            }
+            catch (ProcessFlowInstanceDomainException ex)
+            {
+                return ToError(ex.Errors, HttpStatusCode.BadRequest, Request);
+            }
+            catch(Exception ex)
+            {
+                return ToError(new Dictionary<string, string>
+                {
+                    { "invalid_request", ex.Message }
+                }, HttpStatusCode.BadRequest, Request);
+            }
         }
 
         [HttpGet("{id}")]
@@ -175,6 +206,7 @@ private static JObject ToDto(ProcessFlowInstance flowInstance)
                 { "create_datetime", flowInstance.CreateDateTime },
                 { "template_id", flowInstance.ProcessFlowTemplateId },
                 { "name", flowInstance.ProcessFlowName },
+                { "context", ToDto(flowInstance.ExecutionContext) },
                 { "status", Enum.GetName(typeof(ProcessFlowInstanceStatus), flowInstance.Status).ToLowerInvariant() }
             };
             var planItems = new JArray();
@@ -187,6 +219,17 @@ private static JObject ToDto(ProcessFlowInstance flowInstance)
             return result;
         }
 
+        private static JObject ToDto(ProcessFlowInstanceExecutionContext context)
+        {
+            var jObj = new JObject();
+            foreach (var kvp in context.Variables)
+            {
+                jObj.Add(kvp.Key, kvp.Value);
+            }
+
+            return jObj;
+        }
+
         private static JObject ToDto(CMMNPlanItem planItem)
         {
             return new JObject
@@ -196,5 +239,24 @@ private static JObject ToDto(CMMNPlanItem planItem)
                 { "status", Enum.GetName(typeof(ProcessFlowInstanceElementStatus), planItem.Status).ToLowerInvariant() }
             };
         }
+
+        private static ActionResult ToError(ICollection<KeyValuePair<string, string>> errors, HttpStatusCode statusCode, HttpRequest request)
+        {
+            var problemDetails = new ValidationProblemDetails
+            {
+                Instance = request.Path,
+                Status = (int)statusCode,
+                Detail = "Please refer to the errors property for additional details."
+            };
+            foreach (var kvp in errors.GroupBy(e => e.Key))
+            {
+                problemDetails.Errors.Add(kvp.Key, kvp.Select(s => s.Value).ToArray());
+            }
+
+            return new BadRequestObjectResult(problemDetails)
+            {
+                StatusCode = (int)statusCode
+            };
+        }
     }
 }

src/CaseManagement.CMMN/Apis/CaseInstancesController.cs

@@ -1,8 +1,10 @@
 using CaseManagement.CMMN.CaseInstance.Commands;
+using CaseManagement.CMMN.CaseInstance.Exceptions;
 using CaseManagement.CMMN.Domains;
 using CaseManagement.Workflow.Domains;
 using CaseManagement.Workflow.Infrastructure.EvtBus;
 using CaseManagement.Workflow.Infrastructure.EvtStore;
+using CaseManagement.Workflow.Persistence;
 using Microsoft.Extensions.Options;
 using NEventStore;
 using System.Linq;
@@ -12,10 +14,12 @@ namespace CaseManagement.CMMN.CaseInstance.CommandHandlers
 {
     public class ConfirmFormCommandHandler : BaseCommandHandler<ProcessFlowInstance>, IConfirmFormCommandHandler
     {
+        private readonly IFormQueryRepository _formQueryRepository;
         private readonly IEventStoreRepository<ProcessFlowInstance> _eventStoreRepository;
 
-        public ConfirmFormCommandHandler(IStoreEvents storeEvents, IEventBus eventBus, IEventStoreRepository<ProcessFlowInstance> eventStoreRepository, IAggregateSnapshotStore<ProcessFlowInstance> aggregateSnapshotStore, IOptions<SnapshotConfiguration> snapshotConfiguration) : base(storeEvents, eventBus, aggregateSnapshotStore, snapshotConfiguration)
+        public ConfirmFormCommandHandler(IFormQueryRepository formQueryRepository, IStoreEvents storeEvents, IEventBus eventBus, IEventStoreRepository<ProcessFlowInstance> eventStoreRepository, IAggregateSnapshotStore<ProcessFlowInstance> aggregateSnapshotStore, IOptions<SnapshotConfiguration> snapshotConfiguration) : base(storeEvents, eventBus, aggregateSnapshotStore, snapshotConfiguration)
         {
+            _formQueryRepository = formQueryRepository;
             _eventStoreRepository = eventStoreRepository;
         }
 
@@ -24,16 +28,28 @@ public async Task<bool> Handle(ConfirmFormCommand confirmFormCommand)
             var caseInstance = await _eventStoreRepository.GetLastAggregate(confirmFormCommand.CaseInstanceId, ProcessFlowInstance.GetStreamName(confirmFormCommand.CaseInstanceId));
             if (caseInstance == null || string.IsNullOrWhiteSpace(caseInstance.Id))
             {
-                // TODO : THROW EXCEPTION.
+                throw new UnknownCaseInstanceException(confirmFormCommand.CaseInstanceId);
             }
 
             var flowInstanceElt = caseInstance.Elements.FirstOrDefault(e => e.Id == confirmFormCommand.CaseElementInstanceId) as CMMNPlanItem;
             if (flowInstanceElt == null)
             {
-                // TODO : THROW EXCEPTION.
+                throw new UnknownCaseInstanceElementException(caseInstance.Id, confirmFormCommand.CaseElementInstanceId);
             }
 
-            caseInstance.ConfirmForm(confirmFormCommand.CaseElementInstanceId);
+            var humanTask = flowInstanceElt.PlanItemDefinition as CMMNHumanTask;
+            if (humanTask == null)
+            {
+                throw new NotSupportedTaskException("Task must be a HumanTask");
+            }
+
+            var form = await _formQueryRepository.FindFormById(humanTask.FormId);
+            if (form == null)
+            {
+                throw new UnknownFormException(humanTask.FormId);
+            }
+
+            caseInstance.ConfirmForm(confirmFormCommand.CaseElementInstanceId, form, confirmFormCommand.Content);
             await Commit(caseInstance, caseInstance.GetStreamName());
             return true;
         }

src/CaseManagement.CMMN/CaseInstance/CommandHandlers/ConfirmFormCommandHandler.cs

@@ -112,7 +112,7 @@ private static CMMNTask BuildTask(tTask task)
 
         private static CMMNPlanItemDefinition BuildProcessTask(tProcessTask processTask)
         {
-            var result = new CMMNProcessTask(processTask.name) { AssemblyQualifiedName = processTask.assemblyQualifiedName, IsBlocking = processTask.isBlocking };
+            var result = new CMMNProcessTask(processTask.name) { IsBlocking = processTask.isBlocking };
             if (processTask.parameterMapping != null)
             {
                 foreach(var pm in processTask.parameterMapping)

src/CaseManagement.CMMN/CaseInstance/CommandHandlers/CreateCaseInstanceCommandHandler.cs

@@ -1,11 +1,11 @@
-using System.Runtime.Serialization;
+using Newtonsoft.Json.Linq;
 
 namespace CaseManagement.CMMN.CaseInstance.Commands
 {
-    [DataContract]
     public class ConfirmFormCommand
     {
         public string CaseInstanceId { get; set; }
         public string CaseElementInstanceId { get; set; }
+        public JObject Content { get; set; }
     }
 }

src/CaseManagement.CMMN/CaseInstance/Commands/ConfirmFormCommand.cs

@@ -0,0 +1,9 @@
+using System;
+
+namespace CaseManagement.CMMN.CaseInstance.Exceptions
+{
+    public class NotSupportedTaskException : Exception
+    {
+        public NotSupportedTaskException(string message) : base(message) { }
+    }
+}

src/CaseManagement.CMMN/CaseInstance/Exceptions/NotSupportedTaskException.cs

@@ -0,0 +1,16 @@
+using System;
+
+namespace CaseManagement.CMMN.CaseInstance.Exceptions
+{
+    public class UnknownCaseInstanceElementException : Exception
+    {
+        public UnknownCaseInstanceElementException(string caseInstanceId, string caseInstanceElementId)
+        {
+            CaseInstanceId = caseInstanceId;
+            CaseInstanceElementId = caseInstanceElementId;
+        }
+
+        public string CaseInstanceId { get; set; }
+        public string CaseInstanceElementId { get; set; }
+    }
+}

src/CaseManagement.CMMN/CaseInstance/Exceptions/UnknownCaseInstanceElementException.cs

@@ -0,0 +1,14 @@
+using System;
+
+namespace CaseManagement.CMMN.CaseInstance.Exceptions
+{
+    public class UnknownCaseInstanceException : Exception
+    {
+        public UnknownCaseInstanceException(string caseInstanceId)
+        {
+            CaseInstanceId = caseInstanceId;
+        }
+
+        public string CaseInstanceId { get; set; }
+    }
+}

src/CaseManagement.CMMN/CaseInstance/Exceptions/UnknownCaseInstanceException.cs

@@ -0,0 +1,14 @@
+using System;
+
+namespace CaseManagement.CMMN.CaseInstance.Exceptions
+{
+    public class UnknownFormException : Exception
+    {
+        public UnknownFormException(string formId)
+        {
+            FormId = formId;
+        }
+
+        public string FormId { get; set; }
+    }
+}

src/CaseManagement.CMMN/CaseInstance/Exceptions/UnknownFormException.cs

@@ -28,7 +28,7 @@ public override async Task<bool> Run(CMMNPlanItem cmmnPlanItem, ProcessFlowInsta
             }
 
             var form = await _formQueryRepository.FindFormById(humanTask.FormId);
-            cmmnPlanItem.SetFormInstance(form);
+            cmmnPlanItem.SetFormInstance(ProcessFlowInstanceElementForm.New(form.Id));
             if (humanTask.IsBlocking)
             {
                 return false;