Skip to content

Commit 4dee2de

Browse files
liambeguinTeque5
authored andcommitted
sigmffile: be more specific on except statement
This tries to catch the ValueError raised one line above. Be more specifispecific about the exception type so as to not mask other error. This is a preparatory change for the archive data file fix. Signed-off-by: Liam Beguin <liambeguin@gmail.com>
1 parent bb408d8 commit 4dee2de

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

sigmf/sigmffile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -531,8 +531,8 @@ def set_data_file(self, data_file=None, data_buffer=None, skip_checksum=False, o
531531
buffer_count = -1 if mapped_length is None else mapped_length
532532
raveled = np.frombuffer(self.data_buffer.getbuffer(), count=buffer_count, **common_args)
533533
else:
534-
raise ValueError('In sigmffile.set_data_file(), either data_file or data_buffer must be not None')
535-
except: # TODO include likely exceptions here
534+
raise SigMFFileError('In sigmffile.set_data_file(), either data_file or data_buffer must be not None')
535+
except SigMFFileError: # TODO include likely exceptions here
536536
warnings.warn('Failed to create data array from memory-map-file or buffer!')
537537
else:
538538
self._memmap = raveled.reshape(mapped_reshape)

0 commit comments

Comments
 (0)