Revert "Refactoring Direct3D12 to use constructor logic instead of Factory Create logic."

This reverts commit 7dcca8b.

Author: amerkoleci

Source/SharpDX.Direct3D12/CommandAllocator.cs

@@ -25,59 +25,23 @@ namespace SharpDX.Direct3D12
 {
     public partial class CommandQueue
     {
-        /// <summary>
-        /// Initializes a new instance of the <see cref="CommandQueue"/> class.
-        /// </summary>
-        /// <param name="device">The device with which to associate the command queue.</param>
-        /// <param name="description"><see cref="CommandQueueDescription"/> structure that describes the queue.</param>
-        public CommandQueue(Device device, CommandQueueDescription description)
-            : base(IntPtr.Zero)
-        {
-            device.CreateCommandQueue(
-                ref description,
-                Utilities.GetGuidFromType(typeof(CommandQueue)),
-                this);
-        }
-
         /// <summary>	
         /// <p>Submits a command list for execution.</p>	
         /// </summary>	
-        /// <param name="commandList">The <see cref="SharpDX.Direct3D12.CommandList"/> be executed.</param>	
+        /// <param name="numCommandLists"><dd> <p> The number of command lists to be executed. </p> </dd></param>	
+        /// <param name="commandListsOut"><dd> <p> The array of <strong><see cref="SharpDX.Direct3D12.CommandList"/></strong> command lists to be executed. </p> </dd></param>	
         /// <remarks>	
         /// <p> The driver is free to patch the submitted command lists. It is the calling application?s responsibility to ensure that the graphics processing unit (GPU) is not currently reading the any of the submitted command lists from a previous execution. </p><p> Applications are encouraged to batch together command list executions to reduce fixed costs associated with submitted commands to the GPU. </p>	
         /// </remarks>	
+        /// <include file='.\..\Documentation\CodeComments.xml' path="/comments/comment[@id='ID3D12CommandQueue::ExecuteCommandLists']/*"/>	
+        /// <msdn-id>dn788631</msdn-id>	
+        /// <unmanaged>void ID3D12CommandQueue::ExecuteCommandLists([In] unsigned int NumCommandLists,[In, Buffer] const ID3D12CommandList** ppCommandLists)</unmanaged>	
+        /// <unmanaged-short>ID3D12CommandQueue::ExecuteCommandLists</unmanaged-short>	
         public unsafe void ExecuteCommandList(CommandList commandList)
         {
+            if(commandList == null) throw new ArgumentNullException("commandList");
             var ptr = commandList.NativePointer;
-            ExecuteCommandLists(1, new IntPtr(&ptr));
-        }
-
-        /// <summary>	
-        /// Submits an array of command lists for execution.	
-        /// </summary>	
-        /// <param name="commandLists">
-        /// The array of <see cref="SharpDX.Direct3D12.CommandList"/> command lists to be executed.
-        /// </param>	
-        /// <remarks>	
-        /// The driver is free to patch the submitted command lists.
-        /// It is the calling application's responsibility to ensure that the graphics processing unit (GPU) is not currently reading the any of the submitted command lists from a previous execution.
-        /// Applications are encouraged to batch together command list executions to reduce fixed costs associated with submitted commands to the GPU.
-        /// </remarks>	
-        public unsafe void ExecuteCommandLists(params SharpDX.Direct3D12.CommandList[] commandLists)
-        {
-            var commandListsPtr = (IntPtr*)0;
-
-            int count = 0;
-            if (commandLists != null)
-            {
-                count = commandLists.Length;
-                IntPtr* tempPtr = stackalloc IntPtr[count];
-                commandListsPtr = tempPtr;
-                for (int i = 0; i < count; i++)
-                    commandListsPtr[i] = (commandLists[i] == null) ? IntPtr.Zero : commandLists[i].NativePointer;
-            }
-
-            ExecuteCommandLists(count, new IntPtr(commandListsPtr));
+            this.ExecuteCommandLists(1, new IntPtr(&ptr));
         }
     }
 }

Source/SharpDX.Direct3D12/CommandQueue.cs

@@ -21,22 +21,10 @@ namespace SharpDX.Direct3D12
 {
     public partial struct CommandQueueDescription
     {
-        public CommandQueueDescription(CommandListType type, CommandQueueFlags flags = CommandQueueFlags.None)
+        public CommandQueueDescription(CommandListType type, CommandQueueFlags flags = CommandQueueFlags.None) : this()
         {
             Type = type;
-            Priority = 0;
             Flags = flags;
-            NodeMask = 0;
-        }
-
-        public CommandQueueDescription(
-            CommandListType type,
-            int nodeMask)
-        {
-            Type = type;
-            Priority = 0;
-            Flags = CommandQueueFlags.None;
-            NodeMask = nodeMask;
         }
     }
 }