Merge pull request #10 from second-state/feat/binance-enhancements

feat: Binance enhancements — configurable URL, quote, transfer, tests

Author: juntao

.github/workflows/ci.yml

@@ -40,6 +40,7 @@ jobs:
           ./target/release/binance --help
           ./target/release/coinbase --help
           ./target/release/polymarket --help
+          ./target/release/okx --help
 
       - name: Smoke test - init
         run: |

.github/workflows/release.yml

@@ -9,7 +9,7 @@ permissions:
   contents: write
 
 env:
-  BINARIES: fintool hyperliquid binance coinbase polymarket
+  BINARIES: fintool hyperliquid binance coinbase polymarket okx
 
 jobs:
   build:

Cargo.toml

@@ -31,6 +31,10 @@ path = "src/bin/coinbase.rs"
 name = "polymarket"
 path = "src/bin/polymarket.rs"
 
+[[bin]]
+name = "okx"
+path = "src/bin/okx.rs"
+
 [dependencies]
 clap = { version = "4", features = ["derive"] }
 reqwest = { version = "0.12", default-features = false, features = ["json", "rustls-tls"] }
@@ -60,3 +64,4 @@ hmac = "0.12"
 rmp-serde = "1"
 sha2 = "0.10"
 uuid = { version = "1", features = ["v4"] }
+base64 = "0.22"

README.md

@@ -32,12 +32,24 @@ testnet = false
 # Sign up at https://www.binance.com/
 # binance_api_key = "..."
 # binance_api_secret = "..."
+# Custom base URL (default: https://api.binance.com)
+# For Binance US (spot only, no futures/options): https://api.binance.us
+# binance_base_url = "https://api.binance.com"
 
 # Coinbase Advanced Trade API credentials — enables spot trading on Coinbase
 # Sign up at https://www.coinbase.com/
 # coinbase_api_key = "..."
 # coinbase_api_secret = "..."
 
+# OKX API credentials — enables spot/perp trading on OKX
+# Sign up at https://www.okx.com/
+# okx_api_key = "..."
+# okx_secret_key = "..."
+# okx_passphrase = "..."
+# Custom base URL (default: https://www.okx.com)
+# For OKX US: https://app.okx.com
+# okx_base_url = "https://www.okx.com"
+
 # Polymarket — prediction market trading on Polygon
 # Uses the [wallet] private_key for signing. Only signature_type is configurable.
 # [polymarket]

config.toml.default

@@ -1,6 +1,6 @@
 ---
 name: fintool
-description: "Financial trading CLIs — spot and perp trading on Hyperliquid, Binance, Coinbase. Prediction markets on Polymarket. Deposit and withdraw across chains. LLM-enriched price quotes with trend analysis. News and SEC filings. Use when: user asks about stock/crypto prices, wants to trade, deposit, withdraw, or check portfolio."
+description: "Financial trading CLIs — spot and perp trading on Hyperliquid, Binance, Coinbase, OKX. Prediction markets on Polymarket. Deposit and withdraw across chains. LLM-enriched price quotes with trend analysis. News and SEC filings. Use when: user asks about stock/crypto prices, wants to trade, deposit, withdraw, or check portfolio."
 homepage: https://github.com/second-state/fintool
 metadata: { "openclaw": { "emoji": "📈", "requires": { "bins": ["curl"] } } }
 ---
@@ -17,6 +17,7 @@ A suite of CLI tools for market intelligence and trading across multiple exchang
 | `hyperliquid` | Hyperliquid trading (spot, perp, HIP-3, deposits) | `{baseDir}/scripts/hyperliquid` |
 | `binance` | Binance trading (spot, perp, deposits) | `{baseDir}/scripts/binance` |
 | `coinbase` | Coinbase trading (spot, deposits) | `{baseDir}/scripts/coinbase` |
+| `okx` | OKX trading (spot, perp, deposits, withdrawals) | `{baseDir}/scripts/okx` |
 | `polymarket` | Polymarket prediction markets | `{baseDir}/scripts/polymarket` |
 
 - **Config**: `~/.fintool/config.toml`
@@ -46,25 +47,28 @@ cat ~/.fintool/config.toml 2>/dev/null
    - **Hyperliquid**: `private_key` or `wallet_json` + `wallet_passcode` in `[wallet]` (spot + perps)
    - **Binance**: `binance_api_key` + `binance_api_secret` in `[api_keys]` (spot + perps)
    - **Coinbase**: `coinbase_api_key` + `coinbase_api_secret` in `[api_keys]` (spot only)
+   - **OKX**: `okx_api_key` + `okx_secret_key` + `okx_passphrase` in `[api_keys]` (spot + perps)
    - **Polymarket**: Uses `wallet.private_key` (same as Hyperliquid) for prediction market trading
    - If none configured: Ask the user which exchange they want to use and request the credentials.
 
 **If the user provides credentials**, edit `~/.fintool/config.toml` directly to add them.
 
 ## Exchange Capabilities
 
-| Feature | `hyperliquid` | `binance` | `coinbase` | `polymarket` |
-|---------|---------------|-----------|------------|--------------|
-| Spot orders | buy, sell | buy, sell | buy, sell | — |
-| Perp orders | perp buy/sell | perp buy/sell | — | — |
-| Prediction markets | — | — | — | buy, sell, list, quote |
-| Orderbook | spot + perp | spot + perp | spot | — |
-| Deposit | Unit + Across | API | API | bridge |
-| Withdraw | Bridge2 + Unit + Across | API | API | bridge |
-| Balance | balance | balance | balance | balance |
-| Open orders | orders | orders | orders | — |
-| Cancel | cancel | cancel | cancel | — |
-| Positions | positions | positions | — | positions |
+| Feature | `hyperliquid` | `binance` | `coinbase` | `okx` | `polymarket` |
+|---------|---------------|-----------|------------|-------|--------------|
+| Spot orders | buy, sell | buy, sell | buy, sell | buy, sell | — |
+| Perp orders | perp buy/sell | perp buy/sell | — | perp buy/sell | — |
+| Prediction markets | — | — | — | — | buy, sell, list, quote |
+| Orderbook | spot + perp | spot + perp | spot | spot + perp | — |
+| Deposit | Unit + Across | API | API | API | bridge |
+| Withdraw | Bridge2 + Unit + Across | API | API | API | bridge |
+| Transfer | spot ↔ perp ↔ dex | spot ↔ futures | — | funding ↔ trading | — |
+| Balance | balance | balance | balance | balance | balance |
+| Open orders | orders | orders | orders | orders | — |
+| Cancel | cancel | cancel | cancel | cancel | — |
+| Positions | positions | positions | — | positions | positions |
+| Funding rate | — | — | — | perp funding_rate | — |
 
 ## Error Handling
 
@@ -139,6 +143,38 @@ cat ~/.fintool/config.toml 2>/dev/null
 {"command": "withdraw", "asset": "USDC", "amount": 100, "to": "0x...", "network": "ethereum"}
 ```
 
+### OKX Trading (`okx`)
+
+```json
+// okx --json '<JSON>'
+{"command": "quote", "symbol": "BTC"}
+{"command": "buy", "symbol": "ETH", "amount": 0.01, "price": 2000}
+{"command": "sell", "symbol": "ETH", "amount": 0.01, "price": 2100}
+{"command": "orderbook", "symbol": "BTC"}
+{"command": "perp_orderbook", "symbol": "ETH"}
+{"command": "perp_buy", "symbol": "ETH", "amount": 0.1, "price": 2000}
+{"command": "perp_sell", "symbol": "ETH", "amount": 0.1, "price": 2100, "close": true}
+{"command": "perp_leverage", "symbol": "ETH", "leverage": 5, "cross": true}
+{"command": "perp_funding_rate", "symbol": "BTC"}
+{"command": "balance"}
+{"command": "positions"}
+{"command": "orders"}
+{"command": "cancel", "inst_id": "BTC-USDT", "order_id": "12345"}
+{"command": "deposit", "asset": "USDC", "network": "base"}
+{"command": "deposit", "asset": "ETH", "network": "ethereum"}
+{"command": "withdraw", "asset": "USDC", "amount": 100, "network": "base"}
+{"command": "withdraw", "asset": "USDC", "amount": 100, "to": "0x...", "network": "ethereum"}
+{"command": "transfer", "asset": "USDT", "amount": 100, "from": "funding", "to": "trading"}
+{"command": "transfer", "asset": "USDT", "amount": 100, "from": "trading", "to": "funding"}
+```
+
+**OKX Notes:**
+- `quote` and `orderbook` are public endpoints — no API keys needed.
+- OKX uses instrument IDs: spot = `BTC-USDT`, perp = `BTC-USDT-SWAP`. The CLI auto-formats from symbol.
+- OKX has `funding` (for deposits/withdrawals) and `trading` (unified) accounts. Use `transfer` to move between them.
+- Withdrawal fee is auto-fetched if `--fee` is not specified.
+- Cancel requires both `inst_id` (e.g. `BTC-USDT`) and `order_id`.
+
 ### Coinbase Trading (`coinbase`)
 
 ```json
@@ -209,6 +245,9 @@ Returns: bids, asks, spread, spreadPct, midPrice. Use to assess liquidity before
 
 # Or on Coinbase
 {baseDir}/scripts/coinbase --json '{"command":"buy","symbol":"BTC","amount":0.01,"price":95000}'
+
+# Or on OKX
+{baseDir}/scripts/okx --json '{"command":"buy","symbol":"BTC","amount":0.01,"price":95000}'
 ```
 
 **Step 4 — Verify:**
@@ -260,7 +299,7 @@ Returns: bids, asks, spread, spreadPct, midPrice. Use to assess liquidity before
 ```
 Use `"close": true` to ensure the order only reduces an existing position.
 
-**Note**: Perps are available on `hyperliquid` and `binance`. Coinbase does not support perps.
+**Note**: Perps are available on `hyperliquid`, `binance`, and `okx`. Coinbase does not support perps.
 
 ### Workflow 3: Portfolio Overview
 
@@ -279,6 +318,11 @@ Use `"close": true` to ensure the order only reduces an existing position.
 # Coinbase
 {baseDir}/scripts/coinbase --json '{"command":"balance"}'
 
+# OKX
+{baseDir}/scripts/okx --json '{"command":"balance"}'
+{baseDir}/scripts/okx --json '{"command":"positions"}'
+{baseDir}/scripts/okx --json '{"command":"orders"}'
+
 # Polymarket
 {baseDir}/scripts/polymarket --json '{"command":"balance"}'
 {baseDir}/scripts/polymarket --json '{"command":"positions"}'
@@ -311,10 +355,11 @@ Sends ETH from your wallet on Ethereum L1 to a Unit bridge deposit address. Mini
 ```
 BTC and SOL cannot be bridged automatically. The command returns a Unit deposit address for manual transfer.
 
-**Binance / Coinbase — get deposit address:**
+**Binance / Coinbase / OKX — get deposit address:**
 ```bash
 {baseDir}/scripts/binance --json '{"command":"deposit","asset":"USDC","from":"ethereum"}'
 {baseDir}/scripts/coinbase --json '{"command":"deposit","asset":"ETH"}'
+{baseDir}/scripts/okx --json '{"command":"deposit","asset":"USDC","network":"base"}'
 ```
 
 **Polymarket — deposit USDC:**
@@ -333,10 +378,11 @@ BTC and SOL cannot be bridged automatically. The command returns a Unit deposit
 {baseDir}/scripts/hyperliquid --json '{"command":"withdraw","asset":"ETH","amount":0.5}'
 ```
 
-**Binance / Coinbase:**
+**Binance / Coinbase / OKX:**
 ```bash
 {baseDir}/scripts/binance --json '{"command":"withdraw","asset":"USDC","amount":100,"to":"0x...","network":"ethereum"}'
 {baseDir}/scripts/coinbase --json '{"command":"withdraw","asset":"USDC","amount":100,"to":"0x..."}'
+{baseDir}/scripts/okx --json '{"command":"withdraw","asset":"USDC","amount":100,"network":"base"}'
 ```
 
 **Polymarket:**

skills/SKILL.md

@@ -42,15 +42,25 @@ esac
 echo "Downloading ${ARTIFACT}..."
 curl -L -o /tmp/fintool.zip "${RELEASE_BASE}/${ARTIFACT}.zip"
 unzip -o /tmp/fintool.zip -d /tmp/fintool-extract
-cp "/tmp/fintool-extract/${ARTIFACT}/fintool" "$SKILL_DIR/scripts/fintool"
-chmod +x "$SKILL_DIR/scripts/fintool"
+BINARIES="fintool hyperliquid binance coinbase polymarket okx"
+for bin in $BINARIES; do
+  src="/tmp/fintool-extract/${ARTIFACT}/${bin}"
+  if [ -f "$src" ]; then
+    cp "$src" "$SKILL_DIR/scripts/${bin}"
+    chmod +x "$SKILL_DIR/scripts/${bin}"
+  elif [ -f "${src}.exe" ]; then
+    cp "${src}.exe" "$SKILL_DIR/scripts/${bin}.exe"
+  else
+    echo "⚠️  Binary not found in release: ${bin}"
+  fi
+done
 rm -rf /tmp/fintool.zip /tmp/fintool-extract
 
 # 4. Initialize config (never overwrites existing)
 "$SKILL_DIR/scripts/fintool" init
 
 echo ""
-echo "✅ fintool installed to $SKILL_DIR/scripts/fintool"
+echo "✅ fintool binaries installed to $SKILL_DIR/scripts/"
 echo ""
 
 # 5. Check config for required keys
@@ -76,9 +86,13 @@ fi
 if grep -q '^coinbase_api_key\s*=' "$CONFIG" 2>/dev/null; then
   HAS_COINBASE=true
 fi
+HAS_OKX=false
+if grep -q '^okx_api_key\s*=' "$CONFIG" 2>/dev/null; then
+  HAS_OKX=true
+fi
 
-if [ "$HAS_HL" = false ] && [ "$HAS_BINANCE" = false ] && [ "$HAS_COINBASE" = false ]; then
-  MISSING+=("At least one exchange (Hyperliquid wallet, Binance API keys, or Coinbase API keys)")
+if [ "$HAS_HL" = false ] && [ "$HAS_BINANCE" = false ] && [ "$HAS_COINBASE" = false ] && [ "$HAS_OKX" = false ]; then
+  MISSING+=("At least one exchange (Hyperliquid wallet, Binance API keys, Coinbase API keys, or OKX API keys)")
 fi
 
 if [ ${#MISSING[@]} -gt 0 ]; then
@@ -94,6 +108,7 @@ if [ ${#MISSING[@]} -gt 0 ]; then
   echo "  • Hyperliquid (wallet): spot + perps"
   echo "  • Binance (API key):    spot + perps + options"
   echo "  • Coinbase (API key):   spot only"
+  echo "  • OKX (API key):       spot + perps"
 else
   echo "✅ Configuration looks good!"
 fi

skills/bootstrap.sh

@@ -23,7 +23,7 @@ rm -rf /tmp/fintool-repo
 The bootstrap script will:
 1. Clone skill files to `~/.openclaw/skills/fintool/`
 2. Detect your platform (Linux x86_64/aarch64, macOS Apple Silicon)
-3. Download the correct binary from the latest GitHub release
+3. Download all binaries (fintool, hyperliquid, binance, coinbase, polymarket, okx) from the latest GitHub release
 4. Run `fintool init` to create `~/.fintool/config.toml` (never overwrites existing)
 5. Check config for required keys and tell you what's missing
 
@@ -36,6 +36,7 @@ After installation, edit `~/.fintool/config.toml` to add your credentials:
 - **Hyperliquid** — `private_key` or `wallet_json` + `wallet_passcode` in `[wallet]` (spot + perps)
 - **Binance** — `binance_api_key` + `binance_api_secret` in `[api_keys]` (spot + perps + options)
 - **Coinbase** — `coinbase_api_key` + `coinbase_api_secret` in `[api_keys]` (spot only)
+- **OKX** — `okx_api_key` + `okx_secret_key` + `okx_passphrase` in `[api_keys]` (spot + perps)
 
 Verify installation:
 
@@ -57,8 +58,8 @@ If the bootstrap script fails:
    ```bash
    mkdir -p ~/.openclaw/skills/fintool/scripts
    unzip fintool-<platform>.zip
-   cp fintool-<platform>/fintool ~/.openclaw/skills/fintool/scripts/fintool
-   chmod +x ~/.openclaw/skills/fintool/scripts/fintool
+   cp fintool-<platform>/{fintool,hyperliquid,binance,coinbase,polymarket,okx} ~/.openclaw/skills/fintool/scripts/
+   chmod +x ~/.openclaw/skills/fintool/scripts/*
    ```
 4. Copy the skill definition:
    ```bash

skills/install.md

@@ -102,6 +102,24 @@ enum Commands {
         #[arg(long)]
         dry_run: bool,
     },
+
+    /// Get a price quote for a symbol
+    Quote { symbol: String },
+
+    /// Transfer assets between spot and futures wallets
+    Transfer {
+        /// Asset: USDT, USDC, BTC, ETH, etc.
+        asset: String,
+        /// Amount to transfer
+        #[arg(long)]
+        amount: String,
+        /// Source wallet: spot or futures
+        #[arg(long)]
+        from: String,
+        /// Destination wallet: spot or futures
+        #[arg(long)]
+        to: String,
+    },
 }
 
 #[derive(Subcommand)]
@@ -223,6 +241,15 @@ enum JsonCommand {
         #[serde(default)]
         dry_run: bool,
     },
+    Quote {
+        symbol: String,
+    },
+    Transfer {
+        asset: String,
+        amount: f64,
+        from: String,
+        to: String,
+    },
 }
 
 async fn run_json(json_str: &str) -> Result<()> {
@@ -329,6 +356,13 @@ async fn run_json(json_str: &str) -> Result<()> {
             )
             .await
         }
+        JsonCommand::Quote { symbol } => commands::quote::run_spot(&symbol, true).await,
+        JsonCommand::Transfer {
+            asset,
+            amount,
+            from,
+            to,
+        } => commands::transfer::run(&asset, &fmt_num(amount), &from, &to, EXCHANGE, true).await,
     }
 }
 
@@ -439,6 +473,13 @@ async fn main() -> Result<()> {
             )
             .await
         }
+        Commands::Quote { symbol } => commands::quote::run_spot(&symbol, json_output).await,
+        Commands::Transfer {
+            asset,
+            amount,
+            from,
+            to,
+        } => commands::transfer::run(&asset, &amount, &from, &to, EXCHANGE, json_output).await,
     };
 
     if let Err(e) = result {

src/bin/binance.rs

@@ -465,7 +465,7 @@ async fn run_json(json_str: &str) -> Result<()> {
             amount,
             from,
             to,
-        } => commands::transfer::run(&asset, &fmt_num(amount), &from, &to, true).await,
+        } => commands::transfer::run(&asset, &fmt_num(amount), &from, &to, EXCHANGE, true).await,
         JsonCommand::BridgeStatus => commands::bridge_status::run(true).await,
     }
 }
@@ -628,7 +628,7 @@ async fn main() -> Result<()> {
             amount,
             from,
             to,
-        } => commands::transfer::run(&asset, &amount, &from, &to, json_output).await,
+        } => commands::transfer::run(&asset, &amount, &from, &to, EXCHANGE, json_output).await,
         Commands::BridgeStatus => commands::bridge_status::run(json_output).await,
     };