script_validate_test.go

package script_svc

import (
	"context"
	"testing"

	"github.com/cago-frame/cago/pkg/utils/httputils"
	"github.com/scriptscat/scriptlist/internal/pkg/code"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
)

// assertErrCode checks that err is a *httputils.Error with the expected code.
func assertErrCode(t *testing.T, err error, wantCode int) {
	t.Helper()
	require.Error(t, err)
	var herr *httputils.Error
	require.ErrorAs(t, err, &herr, "expected *httputils.Error")
	assert.Equal(t, wantCode, herr.Code)
}

func TestValidateScriptMeta(t *testing.T) {
	ctx := context.Background()

	tests := []struct {
		name          string
		scriptName    string
		description   string
		tags          []string
		nameUnchanged bool
		descUnchanged bool
		wantErrCode   int
	}{
		// --- valid inputs ---
		{
			name:        "valid simple name and single-sentence description",
			scriptName:  "My Script",
			description: "A simple one-line description.",
			tags:        []string{"tag1", "tag2"},
			wantErrCode: 0,
		},
		{
			name:        "valid name with hyphen",
			scriptName:  "Auto-Fill Script",
			description: "一句简单的中文描述",
			wantErrCode: 0,
		},
		{
			name:        "valid description ending with Chinese period",
			scriptName:  "脚本名称",
			description: "一段简单的脚本描述。",
			wantErrCode: 0,
		},

		// --- name: newline ---
		{
			name:        "name with LF newline",
			scriptName:  "My Script\nWith Newline",
			description: "A simple description.",
			wantErrCode: code.ScriptNameInvalid,
		},
		{
			name:        "name with CR",
			scriptName:  "My Script\rWith CR",
			description: "A simple description.",
			wantErrCode: code.ScriptNameInvalid,
		},

		// --- name: SEO separator punctuation ---
		{
			name:        "name with ASCII comma",
			scriptName:  "Script,keyword1,keyword2",
			description: "A simple description.",
			wantErrCode: code.ScriptNameInvalid,
		},
		{
			name:        "name with Chinese full-width comma",
			scriptName:  "脚本名称，关键词1，关键词2",
			description: "一段描述。",
			wantErrCode: code.ScriptNameInvalid,
		},
		{
			name:        "name with pipe",
			scriptName:  "Script | keyword1 | keyword2",
			description: "A simple description.",
			wantErrCode: code.ScriptNameInvalid,
		},
		{
			name:        "name with ASCII semicolon",
			scriptName:  "Script;keyword1",
			description: "A simple description.",
			wantErrCode: code.ScriptNameInvalid,
		},
		{
			name:        "name with Chinese full-width semicolon",
			scriptName:  "脚本；关键词",
			description: "一段描述。",
			wantErrCode: code.ScriptNameInvalid,
		},

		// --- name: length ---
		{
			name:        "name exactly 51 runes",
			scriptName:  "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxy", // 51 chars
			description: "A simple description.",
			wantErrCode: code.ScriptNameTooLong,
		},
		{
			name:        "name exactly 50 runes",
			scriptName:  "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwx", // 50 chars
			description: "A simple description.",
			wantErrCode: 0,
		},

		// --- description: newline ---
		{
			name:        "description with LF newline",
			scriptName:  "My Script",
			description: "First line.\nSecond line.",
			wantErrCode: code.ScriptDescInvalid,
		},
		{
			name:        "description with CR",
			scriptName:  "My Script",
			description: "First line.\rSecond line.",
			wantErrCode: code.ScriptDescInvalid,
		},

		// --- description: multiple Chinese sentences ---
		{
			name:        "description with two Chinese sentences",
			scriptName:  "脚本名称",
			description: "第一句话。第二句话。",
			wantErrCode: code.ScriptDescInvalid,
		},
		{
			name:        "description with two Chinese sentences separated by space",
			scriptName:  "脚本名称",
			description: "第一句。 第二句。",
			wantErrCode: code.ScriptDescInvalid,
		},
		{
			name:        "description with Chinese exclamation in middle",
			scriptName:  "脚本名称",
			description: "第一句！第二句。",
			wantErrCode: code.ScriptDescInvalid,
		},
		{
			name:        "description with Chinese question in middle",
			scriptName:  "脚本名称",
			description: "第一句？第二句。",
			wantErrCode: code.ScriptDescInvalid,
		},

		// --- description: multiple English sentences ---
		{
			name:        "description with two English sentences",
			scriptName:  "My Script",
			description: "First sentence. Second sentence.",
			wantErrCode: code.ScriptDescInvalid,
		},

		// --- description: length ---
		{
			name:        "description too long (>200 runes)",
			scriptName:  "My Script",
			description: "这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述这是一段非常长的描述还要再多一点",
			wantErrCode: code.ScriptDescTooLong,
		},

		// --- tags ---
		{
			name:        "too many tags",
			scriptName:  "My Script",
			description: "A simple description.",
			tags:        []string{"t1", "t2", "t3", "t4", "t5", "t6"},
			wantErrCode: code.ScriptTagsTooMany,
		},
		{
			name:        "exactly 5 tags",
			scriptName:  "My Script",
			description: "A simple description.",
			tags:        []string{"t1", "t2", "t3", "t4", "t5"},
			wantErrCode: 0,
		},

		// --- skip on unchanged ---
		{
			name:          "skip name validation when name unchanged",
			scriptName:    "Old Name,keyword",
			description:   "A simple description.",
			nameUnchanged: true,
			wantErrCode:   0,
		},
		{
			name:          "skip desc validation when desc unchanged",
			scriptName:    "My Script",
			description:   "第一句。第二句。",
			descUnchanged: true,
			wantErrCode:   0,
		},
		{
			name:          "still validate tags when name and desc unchanged",
			scriptName:    "My Script",
			description:   "A simple description.",
			tags:          []string{"t1", "t2", "t3", "t4", "t5", "t6"},
			nameUnchanged: true,
			descUnchanged: true,
			wantErrCode:   code.ScriptTagsTooMany,
		},
		{
			name:          "do not skip desc when only name unchanged",
			scriptName:    "My Script",
			description:   "第一句。第二句。",
			nameUnchanged: true,
			wantErrCode:   code.ScriptDescInvalid,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			err := validateScriptMeta(ctx, tt.scriptName, tt.description, tt.tags, tt.nameUnchanged, tt.descUnchanged)
			if tt.wantErrCode == 0 {
				assert.NoError(t, err)
			} else {
				assertErrCode(t, err, tt.wantErrCode)
			}
		})
	}
}