Don't use exceptions when checking for existing region (#94)

Flamefire · web-flow · commit 59e8609ec31d · 2020-06-09T13:18:19.000+02:00
diff --git a/src/scorepy/events.cpp b/src/scorepy/events.cpp
@@ -35,12 +35,12 @@ void region_begin(const std::string& region_name, std::string module, std::strin
 
 void region_end(const std::string& region_name)
 {
-    try
+    const auto itRegion = regions.find(region_name);
+    if (itRegion != regions.end())
     {
-        auto& handle = regions.at(region_name);
-        SCOREP_User_RegionEnd(handle.value);
+        SCOREP_User_RegionEnd(itRegion->second.value);
     }
-    catch (std::out_of_range& e)
+    else
     {
         static region_handle error_region;
         static SCOREP_User_ParameterHandle scorep_param = SCOREP_USER_INVALID_PARAMETER;

Original file line number	Diff line number	Diff line change
`@@ -35,12 +35,12 @@ void region_begin(const std::string& region_name, std::string module, std::strin`
`35`	`35`
`36`	`36`	`void region_end(const std::string& region_name)`
`37`	`37`	`{`
`38`		`- try`
	`38`	`+ const auto itRegion = regions.find(region_name);`
	`39`	`+ if (itRegion != regions.end())`
`39`	`40`	`{`
`40`		`- auto& handle = regions.at(region_name);`
`41`		`- SCOREP_User_RegionEnd(handle.value);`
	`41`	`+ SCOREP_User_RegionEnd(itRegion->second.value);`
`42`	`42`	`}`
`43`		`- catch (std::out_of_range& e)`
	`43`	`+ else`
`44`	`44`	`{`
`45`	`45`	`static region_handle error_region;`
`46`	`46`	`static SCOREP_User_ParameterHandle scorep_param = SCOREP_USER_INVALID_PARAMETER;`