Rewrite tests using recspecs

Use recspecs expect form to test gcstats output format.
Normalize numbers and whitespace for stable comparison.

Author: samth

.github/workflows/ci.yml

@@ -19,5 +19,7 @@ jobs:
           version: ${{ matrix.racket-version }}
       - name: Install package
         run: raco pkg install --auto --name gcstats
+      - name: Check package dependencies
+        run: raco setup --check-pkg-deps --pkgs gcstats
       - name: Run tests
         run: raco test gcstats

gcstats/tests/core-test.rkt

@@ -1,32 +1,63 @@
-#lang racket/base
+#lang at-exp racket/base
 
-(require rackunit
-         racket/system
-         racket/port
+(require recspecs
+         recspecs/shell
+         racket/runtime-path
+         racket/format
          racket/string)
 
-;; Test that gcstats runs and produces expected output format
-(define output
-  (with-output-to-string
-    (lambda ()
-      (parameterize ([current-error-port (current-output-port)])
-        ;; Run a simple program that allocates memory to trigger GC
-        (system "racket -l gcstats -e '(for ([i 100000]) (cons i i))'")))))
-
-;; Check that output contains expected sections
-(check-true (string-contains? output "bytes allocated in the heap")
-            "Output should contain allocation info")
-(check-true (string-contains? output "bytes collected by GC")
-            "Output should contain collection info")
-(check-true (string-contains? output "bytes max heap size")
-            "Output should contain max heap size")
-(check-true (string-contains? output "INIT  time")
-            "Output should contain init time")
-(check-true (string-contains? output "MUT   time")
-            "Output should contain mutator time")
-(check-true (string-contains? output "GC    time")
-            "Output should contain GC time")
-(check-true (string-contains? output "TOTAL time")
-            "Output should contain total time")
-(check-true (string-contains? output "Alloc rate")
-            "Output should contain allocation rate")
+;; Test script that allocates memory to trigger GC
+(define-runtime-path test-script "test-script.rkt")
+
+(define cmd (~a "racket -l gcstats -t " test-script))
+
+;; Helper to extract a number from a line matching a pattern
+(define (extract-number pattern output)
+  (define m (regexp-match pattern output))
+  (and m (string->number (regexp-replace* #rx"," (cadr m) ""))))
+
+;; Test that gcstats produces expected output format
+;; We use recspecs-output-filter to normalize numeric values and whitespace
+;; AND validate that key metrics are sane
+(parameterize ([recspecs-output-filter
+                (lambda (s)
+                  ;; Validate numeric values before normalizing
+                  (define allocated (extract-number #px"([0-9,]+) bytes allocated" s))
+                  (define collected (extract-number #px"([0-9,]+) bytes collected" s))
+                  (define max-heap (extract-number #px"([0-9,]+) bytes max heap" s))
+                  (define gc-pct (extract-number #px"%GC time +([0-9.]+)" s))
+
+                  (unless (and allocated (> allocated 0))
+                    (error 'gcstats-test "bytes allocated should be positive, got ~a" allocated))
+                  (unless (and collected (>= collected 0))
+                    (error 'gcstats-test "bytes collected should be non-negative, got ~a" collected))
+                  (unless (and max-heap (> max-heap 0))
+                    (error 'gcstats-test "max heap should be positive, got ~a" max-heap))
+                  (unless (and gc-pct (<= gc-pct 100))
+                    (error 'gcstats-test "GC percentage should be <= 100, got ~a" gc-pct))
+
+                  ;; Replace numbers (with optional commas/decimals) with #
+                  (define no-nums (regexp-replace* #px"[0-9][0-9,]*\\.?[0-9]*" s "#"))
+                  ;; Collapse multiple spaces to single space
+                  (regexp-replace* #px" +" no-nums " "))])
+  @expect/shell[cmd]{
+
+ # bytes allocated in the heap
+ # bytes collected by GC
+ # bytes max heap size
+ # bytes max slop
+ # bytes peak total memory use
+
+Generation #: # collections, #ms, #ms elapsed
+
+INIT time # ms
+MUT time # ms ( # ms elapsed)
+GC time # ms ( # ms elapsed)
+TOTAL time # ms ( # ms elapsed)
+
+Max pause time: # ms
+%GC time # % ( # % elapsed)
+
+Alloc rate # bytes per MUT second
+
+})

gcstats/tests/test-script.rkt

@@ -0,0 +1,3 @@
+#lang racket/base
+;; Simple script that allocates memory to trigger GC
+(for ([i 100000]) (cons i i))

info.rkt

@@ -2,4 +2,4 @@
 
 (define collection 'multi)
 (define deps '("base"))
-(define build-deps '("scribble-lib" "racket-doc" "rackunit-lib"))
+(define build-deps '("scribble-lib" "racket-doc" "at-exp-lib" "recspecs-lib"))