Merge #531: [client]: Add estimate_smart_fee_with_mode call

5ef6ba1 feat: Add estimate_smart_fee_with_mode call (Maycon Fabio)

Pull request description:

  While I was working on peer-observer/peer-observer#362, I realized that corepc `estimatesmartfee` call was missing an optional param which is the `estimate_mode`.

  This PR creates a "secondary" method that also accepts an enum for `estimate_mode`, filling this gap for the method. I ran the integration test that I created with all versions of bitcoin core from `v0.17` to `v30.2`, except `v30.0` which I didn't find the binaries, but I suppose it still works. I tried to understand/follow the repo pattern, so let me know if anything is out of place.

  This is my first PR to corepc, so any feedback is welcome ^^.

ACKs for top commit:
  tcharding:
    ACK 5ef6ba1

Tree-SHA512: 738b1a5fc59782fe934e7f413a0840248eabe6965bbe12807de1fcd70f0bcadd39db74824e3811e0e62f759839918ee6316988358b95b18163747a289c10cb33

Author: tcharding

client/src/client_sync/v17/mod.rs

@@ -321,3 +321,15 @@ impl Serialize for ImportMultiTimestamp {
         }
     }
 }
+
+/// Arg for the `estimatesmartfee` method.
+#[derive(Clone, Copy, Debug, Deserialize, Serialize)]
+#[serde(rename_all = "UPPERCASE")]
+pub enum FeeEstimateMode {
+    /// Use default settings based on other criteria
+    Unset,
+    /// Force estimatesmartfee to use non-conservative estimates
+    Economical,
+    /// Force estimatesmartfee to use conservative estimates
+    Conservative,
+}

client/src/client_sync/v17/util.rs

@@ -33,6 +33,14 @@ macro_rules! impl_client_v17__estimate_smart_fee {
             pub fn estimate_smart_fee(&self, blocks: u32) -> Result<EstimateSmartFee> {
                 self.call("estimatesmartfee", &[blocks.into()])
             }
+
+            pub fn estimate_smart_fee_with_mode(
+                &self,
+                blocks: u32,
+                mode: FeeEstimateMode,
+            ) -> Result<EstimateSmartFee> {
+                self.call("estimatesmartfee", &[blocks.into(), into_json(mode)?])
+            }
         }
     };
 }

client/src/client_sync/v18/mod.rs

@@ -24,7 +24,7 @@ use crate::types::v18::*;
 pub use crate::client_sync::{
     v17::{
         AddNodeCommand, AddressType, ImportMultiRequest, ImportMultiScriptPubKey, ImportMultiTimestamp, Input, Output, SetBanCommand, TemplateRequest,
-        TemplateRules, WalletCreateFundedPsbtInput,
+        TemplateRules, WalletCreateFundedPsbtInput, FeeEstimateMode,
     },
 };
 

client/src/client_sync/v19/mod.rs

@@ -20,7 +20,7 @@ use crate::types::v19::*;
 pub use crate::client_sync::{
     v17::{
         AddNodeCommand, AddressType, ImportMultiRequest, ImportMultiScriptPubKey, ImportMultiTimestamp, Input, Output, SetBanCommand, TemplateRequest,
-        TemplateRules, WalletCreateFundedPsbtInput,
+        TemplateRules, WalletCreateFundedPsbtInput, FeeEstimateMode,
     },
 };
 

client/src/client_sync/v20/mod.rs

@@ -20,7 +20,7 @@ use crate::types::v20::*;
 pub use crate::client_sync::{
     v17::{
         AddressType, AddNodeCommand, ImportMultiRequest, ImportMultiScriptPubKey, ImportMultiTimestamp, Input, Output, SetBanCommand, TemplateRequest, TemplateRules,
-        WalletCreateFundedPsbtInput,
+        WalletCreateFundedPsbtInput, FeeEstimateMode,
     },
 };
 

client/src/client_sync/v21/mod.rs

@@ -24,7 +24,7 @@ use crate::types::v21::*;
 pub use crate::client_sync::{
     v17::{
         AddNodeCommand, AddressType, ImportMultiRequest, ImportMultiScriptPubKey, ImportMultiTimestamp, Input, Output, SetBanCommand, TemplateRequest,
-        TemplateRules, WalletCreateFundedPsbtInput,
+        TemplateRules, WalletCreateFundedPsbtInput, FeeEstimateMode,
     },
 };
 

client/src/client_sync/v22/mod.rs

@@ -21,7 +21,7 @@ use crate::types::v22::*;
 pub use crate::client_sync::{
     v17::{
         AddNodeCommand, AddressType, ImportMultiRequest, ImportMultiScriptPubKey, ImportMultiTimestamp, Input, Output, SetBanCommand, TemplateRequest,
-        TemplateRules, WalletCreateFundedPsbtInput,
+        TemplateRules, WalletCreateFundedPsbtInput, FeeEstimateMode,
     },
     v21::ImportDescriptorsRequest,
 };

client/src/client_sync/v23/mod.rs

@@ -21,7 +21,7 @@ use crate::types::v23::*;
 pub use crate::client_sync::{
     v17::{
         AddNodeCommand, ImportMultiRequest, ImportMultiScriptPubKey, ImportMultiTimestamp, Input, Output, SetBanCommand, TemplateRequest, TemplateRules,
-        WalletCreateFundedPsbtInput,
+        WalletCreateFundedPsbtInput, FeeEstimateMode,
     },
     v21::ImportDescriptorsRequest,
 };

client/src/client_sync/v24/mod.rs

@@ -20,7 +20,7 @@ use crate::types::v24::*;
 pub use crate::client_sync::{
     v17::{
         AddNodeCommand, ImportMultiRequest, ImportMultiScriptPubKey, ImportMultiTimestamp, Input, Output, SetBanCommand, TemplateRequest, TemplateRules,
-        WalletCreateFundedPsbtInput,
+        WalletCreateFundedPsbtInput, FeeEstimateMode,
     },
     v21::ImportDescriptorsRequest,
     v23::AddressType,

client/src/client_sync/v25/mod.rs

@@ -20,7 +20,7 @@ use crate::types::v25::*;
 pub use crate::client_sync::{
     v17::{
         AddNodeCommand, ImportMultiRequest, ImportMultiScriptPubKey, ImportMultiTimestamp, Input, Output, SetBanCommand, TemplateRequest, TemplateRules,
-        WalletCreateFundedPsbtInput,
+        WalletCreateFundedPsbtInput, FeeEstimateMode,
     },
     v21::ImportDescriptorsRequest,
     v23::AddressType,