IIFE function -> IIFE arrow function, fix style issues

Author: Face Kapow

.eslintrc

@@ -36,7 +36,7 @@ rules:
     -
       functions: false
       classes: true
-  no-paran-reassign:
+  no-param-reassign:
     - 2
     -
       props: false

js/__loader.js

@@ -216,7 +216,7 @@
           } else {
             /* eslint-disable max-len */
             evalScriptFn(
-              `(function(require,exports,module,__filename,__dirname){${content}})((function(m){return function(path){return m.require(path)}})(global.module),global.module.exports,global.module,global.module.filename,global.module.dirname)`,
+              `((require,exports,module,__filename,__dirname) => {${content}})(((m) => {return function(path){return m.require(path)}})(global.module),global.module.exports,global.module,global.module.filename,global.module.dirname)`,
               displayPath);
             /* eslint-enable max-len */
           }

js/core/pci/scan.js

@@ -32,7 +32,7 @@ const sizeof = {
   UINT64: 8,
 };
 
-const pciAccessorFactory = (function (addressPort, dataPort) {
+const pciAccessorFactory = ((addressPort, dataPort) => {
   const accessorCache = new Map();
 
   /**
@@ -391,7 +391,7 @@ function locateAcpiDevice(dev) {
 /**
  * Provides enumeration services for the whole PCI configuration space
  */
-const pciSpace = (function (pciAccessorFactoryArg) {
+const pciSpace = ((pciAccessorFactoryArg) => {
   function checkDevice(bus, slot, func, fn) {
     const addr = {
       bus,
@@ -443,7 +443,7 @@ const pciSpace = (function (pciAccessorFactoryArg) {
 /**
  * Service for converting PCI data codes to readable names
  */
-const codeNameResolver = (function () {
+const codeNameResolver = (() => {
   const classCodes = [
     'Unclassified',
     'Mass Storage Controller',
@@ -699,7 +699,7 @@ class PciDevice {
 /**
  * Manages PCI devices
  */
-const pciManager = (function () {
+const pciManager = (() => {
   const devicesMap = new Map();
 
   function addressHash(address) {
@@ -882,7 +882,7 @@ pciManager.each((pciDevice) => {
     path: '/driver/' + driverData.driver,
     data: driverArgs,
     env: {}
-  }).then(function() {}, function(err) {
+  }).then(() => {}, function(err) {
     isolate.log(err);
   });
   */

js/driver/virtio/net.js

@@ -17,7 +17,7 @@ const VirtioDevice = require('./device');
 const runtime = require('../../core');
 const { MACAddress, Interface } = runtime.net;
 
-const virtioHeader = (function () { // eslint-disable-line wrap-iife
+const virtioHeader = (() => {
   const OFFSET_FLAGS = 0;
   const OFFSET_GSO_TYPE = 1;
   // const OFFSET_HDR_LEN = 2;

js/test/unit/net/ip4.js

@@ -79,22 +79,13 @@ function ipFragmentsTest(t, name, length, slices, order, norecv) {
 }
 
 test('receive ip4 fragmented non overlapped', (t) => {
-  const slices = [{
-    offset: 0,
-    len: 8,
-  }, {
-    offset: 8,
-    len: 8,
-  }, {
-    offset: 16,
-    len: 16,
-  }, {
-    offset: 32,
-    len: 16,
-  }, {
-    offset: 48,
-    len: 24,
-  }];
+  const slices = [
+    { offset: 0, len: 8 },
+    { offset: 8, len: 8 },
+    { offset: 16, len: 16 },
+    { offset: 32, len: 16 },
+    { offset: 48, len: 24 },
+  ];
   ipFragmentsTest(t, 'normal ordered', 64, slices, [0, 1, 2, 3, 4]);
   ipFragmentsTest(t, 'reverse ordered', 64, slices, [4, 3, 2, 1, 0]);
   ipFragmentsTest(t, 'mixed ordered', 64, slices, [2, 1, 4, 0, 3]);
@@ -104,22 +95,13 @@ test('receive ip4 fragmented non overlapped', (t) => {
 });
 
 test('receive ip4 fragmented overlapped fragments', (t) => {
-  const slices = [{
-    offset: 0,
-    len: 8,
-  }, {
-    offset: 8,
-    len: 8,
-  }, {
-    offset: 16,
-    len: 16,
-  }, {
-    offset: 24,
-    len: 16,
-  }, {
-    offset: 24,
-    len: 48,
-  }];
+  const slices = [
+    { offset: 0, len: 8 },
+    { offset: 8, len: 8 },
+    { offset: 16, len: 16 },
+    { offset: 24, len: 16 },
+    { offset: 24, len: 48 },
+  ];
   ipFragmentsTest(t, 'fragments left edge overlap', 64, slices, [0, 1, 2, 3, 4]);
   ipFragmentsTest(t, 'fragments full and right edge overlap', 64, slices, [4, 3, 2, 1, 0]);
   ipFragmentsTest(t, 'mixed ordered (fragment 3 is unnecessary)', 64, slices, [2, 1, 4, 0]);
@@ -131,42 +113,16 @@ test('receive ip4 fragmented overlapped fragments', (t) => {
 });
 
 test('receive ip4 fragmented overlapped fragments ladder 1', (t) => {
-  const slices = [{
-    offset: 8,
-    len: 64,
-  }, // [ ========]
-    {
-      offset: 16,
-      len: 56,
-    }, // [  =======]
-    {
-      offset: 24,
-      len: 48,
-    }, // [   ======]
-    {
-      offset: 32,
-      len: 40,
-    }, // [    =====]
-    {
-      offset: 40,
-      len: 32,
-    }, // [     ====]
-    {
-      offset: 48,
-      len: 24,
-    }, // [      ===]
-    {
-      offset: 56,
-      len: 16,
-    }, // [       ==]
-    {
-      offset: 64,
-      len: 8,
-    }, // [        =]
-    {
-      offset: 0,
-      len: 8,
-    }, // [=        ] (last piece)
+  const slices = [
+    { offset: 8, len: 64 },    // [ ========]
+    { offset: 16, len: 56 },   // [  =======]
+    { offset: 24, len: 48 },   // [   ======]
+    { offset: 32, len: 40 },   // [    =====]
+    { offset: 40, len: 32 },   // [     ====]
+    { offset: 48, len: 24 },   // [      ===]
+    { offset: 56, len: 16 },   // [       ==]
+    { offset: 64, len: 8 },    // [        =]
+    { offset: 0, len: 8 },     // [=        ] (last piece)
   ];
   ipFragmentsTest(t, 'normal order', 64, slices, [0, 1, 2, 3, 4, 5, 6, 7, 8]);
   ipFragmentsTest(t, 'reverse order except last', 64, slices, [7, 6, 5, 4, 3, 2, 1, 0, 8]);
@@ -178,42 +134,16 @@ test('receive ip4 fragmented overlapped fragments ladder 1', (t) => {
 });
 
 test('receive ip4 fragmented overlapped fragments ladder 2', (t) => {
-  const slices = [{
-    offset: 0,
-    len: 64,
-  }, // [======== ]
-    {
-      offset: 0,
-      len: 56,
-    }, // [=======  ]
-    {
-      offset: 0,
-      len: 48,
-    }, // [======   ]
-    {
-      offset: 0,
-      len: 40,
-    }, // [=====    ]
-    {
-      offset: 0,
-      len: 32,
-    }, // [====     ]
-    {
-      offset: 0,
-      len: 24,
-    }, // [===      ]
-    {
-      offset: 0,
-      len: 16,
-    }, // [==       ]
-    {
-      offset: 0,
-      len: 8,
-    }, // [=        ]
-    {
-      offset: 64,
-      len: 8,
-    }, // [        =] (last piece)
+  const slices = [
+    { offset: 0, len: 64 },  // [======== ]
+    { offset: 0, len: 56 },  // [=======  ]
+    { offset: 0, len: 48 },  // [======   ]
+    { offset: 0, len: 40 },  // [=====    ]
+    { offset: 0, len: 32 },  // [====     ]
+    { offset: 0, len: 24 },  // [===      ]
+    { offset: 0, len: 16 },  // [==       ]
+    { offset: 0, len: 8 },   // [=        ]
+    { offset: 64, len: 8 },  // [        =] (last piece)
   ];
   ipFragmentsTest(t, 'normal order', 64, slices, [0, 1, 2, 3, 4, 5, 6, 7, 8]);
   ipFragmentsTest(t, 'reverse order except last', 64, slices, [7, 6, 5, 4, 3, 2, 1, 0, 8]);
@@ -225,30 +155,13 @@ test('receive ip4 fragmented overlapped fragments ladder 2', (t) => {
 });
 
 test('receive ip4 fragmented overlapped fragments pyramid', (t) => {
-  const slices = [{
-    offset: 8,
-    len: 56,
-  }, // [ ======= ]
-    {
-      offset: 16,
-      len: 40,
-    }, // [  =====  ]
-    {
-      offset: 24,
-      len: 24,
-    }, // [   ===   ]
-    {
-      offset: 32,
-      len: 8,
-    }, // [    =    ]
-    {
-      offset: 64,
-      len: 8,
-    }, // [        =]
-    {
-      offset: 0,
-      len: 8,
-    }, // [=        ]
+  const slices = [
+    { offset: 8, len: 56 },    // [ ======= ]
+    { offset: 16, len: 40 },   // [  =====  ]
+    { offset: 24, len: 24 },   // [   ===   ]
+    { offset: 32, len: 8 },    // [    =    ]
+    { offset: 64, len: 8 },    // [        =]
+    { offset: 0, len: 8 },     // [=        ]
   ];
   ipFragmentsTest(t, 'normal order', 64, slices, [0, 1, 2, 3, 4, 5]);
   ipFragmentsTest(t, 'reverse order except last two 1', 64, slices, [3, 2, 1, 0, 4, 5]);
@@ -259,30 +172,13 @@ test('receive ip4 fragmented overlapped fragments pyramid', (t) => {
 });
 
 test('receive ip4 fragmented overlapped fragments small chunks', (t) => {
-  const slices = [{
-    offset: 0,
-    len: 8,
-  }, // [=        ]
-    {
-      offset: 16,
-      len: 8,
-    }, // [  =      ]
-    {
-      offset: 32,
-      len: 8,
-    }, // [    =    ]
-    {
-      offset: 48,
-      len: 8,
-    }, // [      =  ]
-    {
-      offset: 64,
-      len: 8,
-    }, // [        =]
-    {
-      offset: 8,
-      len: 56,
-    }, // [ ======= ]
+  const slices = [
+    { offset: 0, len: 8 },  // [=        ]
+    { offset: 16, len: 8 }, // [  =      ]
+    { offset: 32, len: 8 }, // [    =    ]
+    { offset: 48, len: 8 }, // [      =  ]
+    { offset: 64, len: 8 }, // [        =]
+    { offset: 8, len: 56 }, // [ ======= ]
   ];
   ipFragmentsTest(t, 'normal order', 64, slices, [0, 1, 2, 3, 4, 5]);
   ipFragmentsTest(t, 'reverse order', 64, slices, [5, 4, 3, 2, 1, 0]);
@@ -292,25 +188,19 @@ test('receive ip4 fragmented overlapped fragments small chunks', (t) => {
 });
 
 test('receive ip4 fragmented max offset and size', (t) => {
-  const slices = [{
-    offset: 0,
-    len: 65528,
-  }, {
-    offset: 65528,
-    len: 7,
-  }];
+  const slices = [
+    { offset: 0, len: 65528 },
+    { offset: 65528, len: 7 },
+  ];
   ipFragmentsTest(t, 'max size', 65535 - 8, slices, [0, 1]);
   t.end();
 });
 
 test('receive ip4 fragmented too big', (t) => {
-  const slices = [{
-    offset: 0,
-    len: 65528,
-  }, {
-    offset: 65528,
-    len: 7 + 1,
-  }];
+  const slices = [
+    { offset: 0, len: 65528 },
+    { offset: 65528, len: 7 + 1 },
+  ];
   ipFragmentsTest(t, 'max-size + 1', (65535 - 8) + 1, slices, [0, 1], true);
   t.end();
 });