NFC: When passing a zero vector as a parameter use {0, 0, 0} instead of {}

In addition unify `Vector` variable initialization style.

Author: Peter Ruevski

src/clipboard.cpp

@@ -209,7 +209,7 @@ void GraphicsWindow::PasteClipboard(Vector trans, double theta, double scale) {
             // Likewise the scale, which could otherwise take us out of the
             // workplane.
             pt = pt.ScaledBy(fabs(scale));
-            pt = pt.ScaleOutOfCsys(u, v, {});
+            pt = pt.ScaleOutOfCsys(u, v, {0, 0, 0});
             pt = pt.Plus(p);
             pt = pt.RotatedAbout(n, theta);
             pt = pt.Plus(trans);

src/drawconstraint.cpp

@@ -886,7 +886,7 @@ void Constraint::DoLayout(DrawAs how, Canvas *canvas,
         }
 
         case Type::PERPENDICULAR: {
-            Vector u{}, v{};
+            Vector u = {}, v = {};
             Vector rn, ru;
             if(workplane == Entity::FREE_IN_3D) {
                 rn = gn;

src/drawentity.cpp

@@ -263,8 +263,8 @@ void Entity::ComputeInterpolatingSpline(SBezierList *sbl, bool periodic) const {
 
     // The starting and finishing control points that define our end tangents
     // (if the spline isn't periodic), and the on-curve points.
-    Vector ctrl_s{};
-    Vector ctrl_f{};
+    Vector ctrl_s = {};
+    Vector ctrl_f = {};
     Vector pt[MAX_N+4];
     if(periodic) {
         for(i = 0; i < ep + 3; i++) {

src/export.cpp

@@ -246,10 +246,10 @@ void SolveSpaceUI::ExportViewOrWireframeTo(const Platform::Path &filename, bool
     }
 
     if(exportWireframe) {
-        Vector u{1.0, 0.0, 0.0},
-               v{0.0, 1.0, 0.0},
-               n{0.0, 0.0, 1.0},
-               origin{};
+        Vector u = {1.0, 0.0, 0.0},
+               v = {0.0, 1.0, 0.0},
+               n = {0.0, 0.0, 1.0},
+               origin = {};
         double cameraTan = 0.0,
                scale = 1.0;
 

src/exportvector.cpp

@@ -311,10 +311,10 @@ class DxfWriteInterface : public DRW_Interface {
     int findDxfColor(const RgbaColor &src) {
         int best = 0;
         double minDist = VERY_POSITIVE;
-        Vector srcv    = {src.redF(), src.greenF(), src.blueF()};
+        Vector srcv = {src.redF(), src.greenF(), src.blueF()};
         for(int i = 1; i < 256; i++) {
             RgbaColor dst = RGBi(DRW::dxfColors[i][0], DRW::dxfColors[i][1], DRW::dxfColors[i][2]);
-            Vector dstv   = {dst.redF(), dst.greenF(), dst.blueF()};
+            Vector dstv = {dst.redF(), dst.greenF(), dst.blueF()};
             double dist = srcv.Minus(dstv).Magnitude();
             if(dist < minDist || best == 0) {
                 best = i;

src/generate.cpp

@@ -421,7 +421,7 @@ void SolveSpaceUI::ForceReferences() {
         Entity *wrkpl = SK.GetEntity(hr.entity(0));
         // The origin for our coordinate system, always zero
         Entity *origin = SK.GetEntity(wrkpl->point[0]);
-        origin->PointForceTo({});
+        origin->PointForceTo({0, 0, 0});
         origin->construction = true;
         SK.GetParam(origin->param[0])->known = true;
         SK.GetParam(origin->param[1])->known = true;

src/graphicswin.cpp

@@ -1216,7 +1216,7 @@ void GraphicsWindow::MenuEdit(Command id) {
             norm = norm.WithMagnitude(1);
             Quaternion qaa = Quaternion::From(norm, PI/2);
 
-            g->TransformImportedBy({}, qaa);
+            g->TransformImportedBy({0, 0, 0}, qaa);
 
             // and regenerate as necessary.
             SS.MarkGroupDirty(hg);

src/group.cpp

@@ -1002,7 +1002,7 @@ void Group::MakeRevolveEndFaces(EntityList *el, hEntity pt, int ai, int af)
 
     // When there is no loop normal (e.g. if the loop is broken), use normal of workplane
     // as fallback, to avoid breaking constraints depending on the faces.
-    if(n.Equals({}) && src->type == Group::Type::DRAWING_WORKPLANE) {
+    if(n.Equals({0, 0, 0}) && src->type == Group::Type::DRAWING_WORKPLANE) {
         n = SK.GetEntity(src->h.entity(0))->Normal()->NormalN();
     }
 
@@ -1039,7 +1039,7 @@ void Group::MakeExtrusionTopBottomFaces(EntityList *el, hEntity pt)
 
     // When there is no loop normal (e.g. if the loop is broken), use normal of workplane
     // as fallback, to avoid breaking constraints depending on the faces.
-    if(n.Equals({}) && src->type == Group::Type::DRAWING_WORKPLANE) {
+    if(n.Equals({0, 0, 0}) && src->type == Group::Type::DRAWING_WORKPLANE) {
         n = SK.GetEntity(src->h.entity(0))->Normal()->NormalN();
     }
 

src/importidf.cpp

@@ -339,8 +339,8 @@ bool LinkIDF(const Platform::Path &filename, EntityList *el, SMesh *m, SShell *s
 
     hEntity hprev;
     hEntity hprevTop;
-    Vector pprev{}; 
-    Vector pprevTop{}; 
+    Vector pprev = {}; 
+    Vector pprevTop = {}; 
 
     double board_thickness = 10.0;
     double scale = 1.0; //mm
@@ -522,7 +522,7 @@ bool LinkIDF(const Platform::Path &filename, EntityList *el, SMesh *m, SShell *s
     double ctc = SS.chordTolCalculated;
     if(ctc == 0.0) SS.chordTolCalculated = 0.1; //mm
     // there should only by one sbls in the sblss unless a board has disjointed parts...
-    sh->MakeFromExtrusionOf(sblss.l.First(), {},
+    sh->MakeFromExtrusionOf(sblss.l.First(), {0, 0, 0},
                                    {0.0, 0.0, board_thickness},
                                    RgbaColor::From(0, 180, 0) );
     SS.chordTolCalculated = ctc;

src/importmesh.cpp

@@ -87,7 +87,7 @@ static hEntity newNormal(EntityList *el, int *id, Quaternion normal, hEntity p)
     en.construction = false;
     en.style.v = Style::NORMALS;
     // to be visible we need to add a point.
-//    en.point[0] = newPoint(el, id, {});
+//    en.point[0] = newPoint(el, id, {0, 0, 0});
     en.point[0] = p;
     en.actVisible = true;
     en.forceHidden = false;