Use a constructor for Enum conversion from Ruby values

Author: georgyangelov

ext/v8/enum.h

@@ -0,0 +1,37 @@
+#include "rr.h"
+
+#ifndef ENUM_H
+#define ENUM_H
+
+namespace rr {
+
+  template <class T>
+  class Enum {
+    VALUE value;
+    T defaultValue;
+
+  public:
+    Enum(VALUE value_, T defaultValue_) : value(value_), defaultValue(defaultValue_) { }
+
+    operator T() {
+      return RTEST(value) ? (T)NUM2INT(value) : defaultValue;
+    }
+  };
+
+  inline void DefineEnums() {
+    ClassBuilder("AccessControl").
+      defineConst("DEFAULT", INT2FIX(v8::DEFAULT)).
+      defineConst("ALL_CAN_READ", INT2FIX(v8::ALL_CAN_READ)).
+      defineConst("ALL_CAN_WRITE", INT2FIX(v8::ALL_CAN_WRITE)).
+      defineConst("PROHIBITS_OVERWRITING", INT2FIX(v8::PROHIBITS_OVERWRITING));
+
+    ClassBuilder("PropertyAttribute").
+      defineConst("None", INT2FIX(v8::None)).
+      defineConst("ReadOnly", INT2FIX(v8::ReadOnly)).
+      defineConst("DontEnum", INT2FIX(v8::DontEnum)).
+      defineConst("DontDelete", INT2FIX(v8::DontDelete));
+  }
+
+};
+
+#endif /* ENUM_H */

ext/v8/enums.h

@@ -9,7 +9,7 @@ using namespace rr;
 extern "C" {
   void Init_init() {
     V8::Init();
-    Enums::Init();
+    DefineEnums();
     Isolate::Init();
     Handles::Init();
     Context::Init();

ext/v8/init.cc

@@ -93,8 +93,8 @@ namespace rr {
       &PropertyCallbackInfo::invokeGetter,
       RTEST(setter) ? &PropertyCallbackInfoVoid::invokeSetter : 0,
       v8::MaybeLocal<v8::Value>(PropertyCallbackInfo::wrapData(isolate, getter, setter, data)),
-      RTEST(settings) ? Enums::fromRubyValue<v8::AccessControl>(settings) : v8::DEFAULT,
-      RTEST(attribute) ? Enums::fromRubyValue<v8::PropertyAttribute>(attribute) : v8::None
+      Enum<v8::AccessControl>(settings, v8::DEFAULT),
+      Enum<v8::PropertyAttribute>(attribute, v8::None)
     ));
   }
 

ext/v8/object.cc

@@ -17,7 +17,7 @@ inline VALUE not_implemented(const char* message) {
 }
 
 #include "class_builder.h"
-#include "enums.h"
+#include "enum.h"
 
 #include "maybe.h"
 #include "equiv.h"