Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Commit 7fc20dc

Browse files
committed
resolve merge conflicts
1 parent 0e4d915 commit 7fc20dc

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

ext/v8/object.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace rr {
2727
Locker lock(isolate);
2828

2929
if (rb_obj_is_kind_of(key, rb_cNumeric)) {
30-
return Bool::Maybe(object->Set(context, UInt32_t(key), Value::rubyObjectToHandle(isolate, value)));
30+
return Bool::Maybe(object->Set(context, Uint32_t(key), Value::rubyObjectToHandle(isolate, value)));
3131
} else {
3232
return Bool::Maybe(object->Set(context, *Value(key), Value::rubyObjectToHandle(isolate, value)));
3333
}
@@ -40,7 +40,7 @@ namespace rr {
4040
Locker lock(isolate);
4141

4242
if (rb_obj_is_kind_of(key, rb_cNumeric)) {
43-
return Value::Maybe(isolate, object->Get(context, UInt32_t(key)));
43+
return Value::Maybe(isolate, object->Get(context, Uint32_t(key)));
4444
} else {
4545
return Value::Maybe(isolate, object->Get(context, *Value(key)));
4646
}

spec/c/function_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
expect(@ctx.Global.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'one')).FromJust()).to eq one
2828
expect(@ctx.Global.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'two')).FromJust()).to eq two
29-
expect(@ctx.Global.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'three')).FromJust()).to eq 3
29+
expect(@ctx.Global.Get(@ctx, V8::C::String.NewFromUtf8(@isolate, 'three')).FromJust().Value()).to eq 3
3030
end
3131

3232
it 'can be called as a constructor' do

0 commit comments

Comments
 (0)