Add Object::Get(Own)PropertyNames

Author: georgyangelov

ext/v8/array.h

@@ -13,6 +13,8 @@ namespace rr {
 
     inline Array(v8::Isolate* isolate, v8::Handle<v8::Array> array) : Ref<v8::Array>(isolate, array) {}
     inline Array(VALUE value) : Ref<v8::Array>(value) {}
+
+    typedef MaybeLocal<Array, v8::Array> Maybe;
   };
 
 }

ext/v8/object.cc

@@ -16,6 +16,8 @@ namespace rr {
       defineMethod("DefineOwnProperty", &DefineOwnProperty).
       defineMethod("GetPropertyAttributes", &GetPropertyAttributes).
       defineMethod("GetOwnPropertyDescriptor", &GetOwnPropertyDescriptor).
+      defineMethod("GetPropertyNames", &GetPropertyNames).
+      defineMethod("GetOwnPropertyNames", &GetOwnPropertyNames).
 
       store(&Class);
   }
@@ -167,6 +169,20 @@ namespace rr {
     ));
   }
 
+  VALUE Object::GetPropertyNames(VALUE self, VALUE r_context) {
+    Object object(self);
+    Locker lock(object);
+
+    return Array::Maybe(object.getIsolate(), object->GetPropertyNames(Context(r_context)));
+  }
+
+  VALUE Object::GetOwnPropertyNames(VALUE self, VALUE r_context) {
+    Object object(self);
+    Locker lock(object);
+
+    return Array::Maybe(object.getIsolate(), object->GetOwnPropertyNames(Context(r_context)));
+  }
+
   Object::operator VALUE() {
     Isolate isolate(getIsolate());
     Locker lock(isolate);

ext/v8/object.h

@@ -21,6 +21,8 @@ namespace rr {
     static VALUE DefineOwnProperty(int argc, VALUE* argv, VALUE self);
     static VALUE GetPropertyAttributes(VALUE self, VALUE r_context, VALUE key);
     static VALUE GetOwnPropertyDescriptor(VALUE self, VALUE r_context, VALUE key);
+    static VALUE GetPropertyNames(VALUE self, VALUE r_context);
+    static VALUE GetOwnPropertyNames(VALUE self, VALUE r_context);
 
     inline Object(VALUE value) : Ref<v8::Object>(value) {}
     inline Object(v8::Isolate* isolate, v8::Handle<v8::Object> object) : Ref<v8::Object>(isolate, object) {}

spec/c/object_spec.rb

@@ -214,6 +214,42 @@
     end
   end
 
+  describe '#GetPropertyNames' do
+    it 'can get array of attribute names' do
+      o = V8::C::Object.New(@isolate)
+      key_one = V8::C::String.NewFromUtf8(@isolate, 'foo 1')
+      key_two = V8::C::String.NewFromUtf8(@isolate, 'foo 2')
+      data = V8::C::String.NewFromUtf8(@isolate, 'data')
+
+      expect(o.DefineOwnProperty(@ctx, key_one, data)).to be_successful
+      expect(o.DefineOwnProperty(@ctx, key_two, data)).to be_successful
+
+      names = o.GetPropertyNames(@ctx)
+      expect(names).to be_successful
+
+      expect(names.FromJust.Get(@ctx, 0)).to v8_eq key_one
+      expect(names.FromJust.Get(@ctx, 1)).to v8_eq key_two
+    end
+  end
+
+  describe '#GetOwnPropertyNames' do
+    it 'can get array of attribute names' do
+      o = V8::C::Object.New(@isolate)
+      key_one = V8::C::String.NewFromUtf8(@isolate, 'foo 1')
+      key_two = V8::C::String.NewFromUtf8(@isolate, 'foo 2')
+      data = V8::C::String.NewFromUtf8(@isolate, 'data')
+
+      expect(o.DefineOwnProperty(@ctx, key_one, data)).to be_successful
+      expect(o.DefineOwnProperty(@ctx, key_two, data)).to be_successful
+
+      names = o.GetOwnPropertyNames(@ctx)
+      expect(names).to be_successful
+
+      expect(names.FromJust.Get(@ctx, 0)).to v8_eq key_one
+      expect(names.FromJust.Get(@ctx, 1)).to v8_eq key_two
+    end
+  end
+
   # TODO: Enable this when the methods are implemented in the extension
   # it 'can retrieve all property names' do
   #   o = V8::C::Object.New