Merge pull request #381 from cowboyd/4.5/finish-array-c-api

finish out the Array C API

Author: cowboyd

ext/v8/array.cc

@@ -25,16 +25,16 @@ namespace rr {
 
   VALUE Array::Length(VALUE self) {
     Array array(self);
-    Locker lock(array.getIsolate());
+    Locker lock(array);
 
     return Uint32_t(array->Length());
   }
 
-  VALUE Array::CloneElementAt(VALUE self, VALUE index) {
+  VALUE Array::CloneElementAt(VALUE self, VALUE context, VALUE index) {
     Array array(self);
-    Locker lock(array.getIsolate());
+    Locker lock(array);
 
-    return Object(array.getIsolate(), array->CloneElementAt(Uint32_t(index)));
+    return Object::Maybe(array.getIsolate(), array->CloneElementAt(Context(context), Uint32_t(index)));
   }
 
 }

ext/v8/array.h

@@ -9,7 +9,7 @@ namespace rr {
 
     static VALUE New(int argc, VALUE argv[], VALUE self);
     static VALUE Length(VALUE self);
-    static VALUE CloneElementAt(VALUE self, VALUE index);
+    static VALUE CloneElementAt(VALUE self, VALUE context, VALUE index);
 
     inline Array(v8::Isolate* isolate, v8::Handle<v8::Array> array) : Ref<v8::Array>(isolate, array) {}
     inline Array(VALUE value) : Ref<v8::Array>(value) {}

spec/c/array_spec.rb

@@ -17,7 +17,20 @@
 
   it 'can be initialized with a length' do
     a = V8::C::Array::New(@isolate, 5)
-
     expect(a.Length).to eq 5
   end
+
+  it 'can clone its elements' do
+    o = V8::C::Object::New(@isolate)
+    key = V8::C::String::NewFromUtf8(@isolate, "key")
+    o.Set(@ctx, key, key)
+    a = V8::C::Array::New(@isolate)
+
+    a.Set(@ctx, 0, o)
+
+    object = a.CloneElementAt(@ctx, 0)
+    expect(object).to be_successful
+    expect(object.FromJust().Get(@ctx, key)).to be_successful
+    expect(object.FromJust().Get(@ctx, key).FromJust().Utf8Value()).to eql "key"
+  end
 end

spec/v8/context_spec.rb

@@ -654,7 +654,7 @@
 
 #   end
 
-   describe "Calling JavaScript Code From Within Ruby", :compat => '0.1.0' do
+   describe "Calling JavaScript Code From Within Ruby"  do
 
     before(:each) do
       @cxt = V8::Context.new