Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Commit 9957716

Browse files
committed
Improve --with-system-v8 error message
Every time I run into this message I struggle to understand what it's telling me to do. This new error message clearly state the option that caused it (`--with-system-v8`) and it clearly focuses on the problem at hand: the system v8 wasn't found. This commit also fixes the typos and removes the unnecessary signature.
1 parent 78ee254 commit 9957716

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

ext/libv8/location.rb

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,15 @@ def configure(context = MkmfContext.new)
5454
class NotFoundError < StandardError
5555
def initialize(*args)
5656
super(<<-EOS)
57-
You have chosen to use the version of V8 found on your system
58-
and *not* the one that is bundle with the libv8 rubygem. However,
59-
it could not be located. please make sure you have a version of
60-
v8 that is compatible with #{Libv8::VERSION} installed. You may
61-
need to special --with-v8-dir options if it is in a non-standard
62-
location
57+
By using --with-system-v8, you have chosen to use the version
58+
of V8 found on your system and *not* the one that is bundled with
59+
the libv8 rubygem.
6360
64-
thanks,
65-
The Mgmt
61+
However, your system version of v8 could not be located.
6662
63+
Please make sure your system version of v8 that is compatible
64+
with #{Libv8::VERSION} installed. You may need to use the
65+
--with-v8-dir option if it is installed in a non-standard location
6766
EOS
6867
end
6968
end

0 commit comments

Comments
 (0)