Merge branch 'disable-warnings'

Author: ignisf

ext/libv8/builder.rb

@@ -20,7 +20,7 @@ def make_target
       profile = enable_config('debug') ? 'debug' : 'release'
       "#{libv8_arch}.#{profile}"
     end
-    
+
     def make_flags(*flags)
       # FreeBSD uses gcc 4.2 by default which leads to
       # compilation failures due to warnings about aliasing.
@@ -49,24 +49,29 @@ def make_flags(*flags)
     end
 
     def build_libv8!
+      checkout!
+      setup_python!
       Dir.chdir(V8_Source) do
-        fail 'No compilers available' if @compiler.nil?
-        checkout!
-        setup_python!
         setup_build_deps!
-        patch! *patch_directories_for(@compiler)
+        fail 'No compilers available' if @compiler.nil?
+        patch!
         print_build_info
+        puts 'Beginning compilation. This will take some time.'
+
+        command = "env CXX=#{@compiler} LINK=#{@compiler}"
 
         case RUBY_PLATFORM
         when /mingw/
           # use a script that will fix the paths in the generated Makefiles
           # don't use make_flags otherwise it will trigger a rebuild of the Makefiles
           system "env CXX=#{@compiler} LINK=#{@compiler} bash #{PATCH_DIRECTORY}/mingw-generate-makefiles.sh"
-          system "env CXX=#{@compiler} LINK=#{@compiler} make #{make_target}"
-          
+          command += " make #{make_target}"
         else
-          puts `env CXX=#{@compiler} LINK=#{@compiler} #{make} #{make_flags}`
+          command += "  #{make} #{make_flags}"
         end
+
+        puts "Building v8 with #{command}"
+        system command
       end
       return $?.exitstatus
     end

ext/libv8/patcher.rb

@@ -4,52 +4,15 @@ module Patcher
 
     module_function
 
-    def patch_directories_for(compiler)
-      patch_directories = []
-
-      case
-      when compiler.target =~ /arm/
-        patch_directories << 'arm'
-      end
-
-      case compiler
-      when Compiler::GCC
-        patch_directories << 'gcc48' if compiler.version >= '4.8'
-      when Compiler::Clang
-        patch_directories << 'clang'
-        patch_directories << 'clang33' if compiler.version >= '3.3'
-        patch_directories << 'clang51' if compiler.version >= '5.1'
-        patch_directories << 'clang70' if compiler.version >= '7.0'
-        patch_directories << 'clang73' if compiler.version >= '7.3'
-      end
-
-      patch_directories
-    end
-
-    def patch_directories(*additional_directories)
-      absolute_paths = [PATCH_DIRECTORY]
-
-      additional_directories.each do |directory|
-        absolute_paths << File.join(PATCH_DIRECTORY, directory)
-      end
-
-      absolute_paths.uniq
-    end
-
-    def patches(*additional_directories)
-      patch_directories(*additional_directories).map do |directory|
-        Dir.glob(File.join directory, '*.patch')
-      end.flatten.sort
-    end
-
-    def patch!(*additional_directories)
+    def patch!
       File.open(".applied_patches", File::RDWR|File::CREAT) do |f|
-        available_patches = patches *additional_directories
+        available_patches = Dir.glob(File.join(PATCH_DIRECTORY, '*.patch'))
         applied_patches = f.readlines.map(&:chomp)
 
         (available_patches - applied_patches).each do |patch|
+          puts "Applying #{patch}"
           `patch -p1 -N < #{patch}`
-          fail 'failed to apply patch' unless $?.success?
+          fail "failed to apply patch #{patch}" unless $?.success?
           f.puts patch
         end
       end

patches/clang/no-unused-private-field.patch

@@ -0,0 +1,12 @@
+diff --git a/build/standalone.gypi b/build/standalone.gypi
+index 125c5bf..de1924c 100644
+--- a/build/standalone.gypi
++++ b/build/standalone.gypi
+@@ -194,7 +194,6 @@
+           'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
+           'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',      # -fvisibility=hidden
+           'GCC_THREADSAFE_STATICS': 'NO',           # -fno-threadsafe-statics
+-          'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES',    # -Werror
+           'GCC_VERSION': 'com.apple.compilers.llvmgcc42',
+           'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES',  # -Wnewline-eof
+           # MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min