Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Commit 864d80e

Browse files
committed
Enable the -fPIC flag for arm, too
It seems that -fPIC is required for 32-bit ARM, too. Trying to link against libv8 on an armv7l was causing the following linking error: relocation R_ARM_THM_MOVW_ABS_NC against `a local symbol' can not be used when making a shared object; recompile with -fPIC
1 parent 02f53ed commit 864d80e

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
### Unreleased
22

3+
* Enable the -fPIC flag for ARM
4+
35
### 5.0.71.48.2, 5.0.71.48.3 - 2016-05-13:
46

57
* Upgrade upstream v8 version to 5.0.71.45

patches/fPIC-for-static.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ index 1252094..308a7e3 100644
77
'cflags': [ '-fvisibility=hidden' ],
88
}],
99
- [ 'component=="shared_library"', {
10-
+ [ 'component=="shared_library" or component=="static_library" and (v8_target_arch=="x64" or v8_target_arch=="arm64")', {
10+
+ [ 'component=="shared_library" or component=="static_library" and (v8_target_arch=="x64" or v8_target_arch=="arm64" or v8_target_arch=="arm")', {
1111
'cflags': [ '-fPIC', ],
1212
}],
1313
[ 'coverage==1', {

0 commit comments

Comments
 (0)