Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Commit 77b96d4

Browse files
committed
Forcefully append MAKEFLAGS contents to make command
Because it seems that the V8 build system does not like to take into account the MAKEFLAGS varible.
1 parent e442d53 commit 77b96d4

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ namespace :build do
7070
sh "vagrant ssh -c 'rm -rf ~/libv8'"
7171
sh "vagrant ssh -c 'git clone /libv8/.git ~/libv8 --recursive'"
7272
sh "vagrant ssh -c 'cd ~/libv8 && bundle install --path vendor/bundle'"
73-
sh "vagrant ssh -c 'cd ~/libv8 && env MAKEFLAGS+=-j4 bundle exec rake binary'"
73+
sh "vagrant ssh -c 'cd ~/libv8 && env MAKEFLAGS=-j4 bundle exec rake binary'"
7474
sh "vagrant ssh -c 'cp ~/libv8/pkg/*.gem /vagrant'"
7575
sh("vagrant status | grep scaleway") do |ok, res|
7676
sh "vagrant ssh --no-tty -c 'cd ~/libv8/pkg && tar -cf - *.gem' 2>/dev/null | tar -xv"

ext/libv8/builder.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,10 @@ def make_flags(*flags)
5959
# Append GYP variable definitions
6060
flags << gyp_defines
6161

62+
# Append manually specified MAKEFLAGS
63+
flags << ENV['MAKEFLAGS'] if ENV['MAKEFLAGS']
64+
ENV['MAKEFLAGS'] = nil
65+
6266
"#{make_target} #{flags.join ' '}"
6367
end
6468

0 commit comments

Comments
 (0)