Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Commit 683c5f8

Browse files
committed
Set the GYP_DEFINES environment variable when syncing dependencies
This closes #233
1 parent 51d779b commit 683c5f8

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

ext/libv8/builder.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,15 @@ def setup_build_deps!
110110
ENV['PATH'] = "#{File.expand_path('../../../vendor/depot_tools', __FILE__)}:#{ENV['PATH']}"
111111
Dir.chdir(File.expand_path('../../../vendor', __FILE__)) do
112112
unless Dir.exists? 'v8'
113-
system "fetch v8" or fail "unable to fetch v8 source"
113+
system "env #{gyp_defines} fetch v8" or fail "unable to fetch v8 source"
114114
else
115-
system "gclient fetch" or fail "could not fetch v8 build dependencies commits"
115+
system "env #{gyp_defines} gclient fetch" or fail "could not fetch v8 build dependencies commits"
116116
end
117117
Dir.chdir('v8') do
118118
unless system "git checkout #{source_version}"
119119
fail "unable to checkout source for v8 #{source_version}"
120120
end
121-
system "gclient sync" or fail "could not sync v8 build dependencies"
121+
system "env #{gyp_defines} gclient sync" or fail "could not sync v8 build dependencies"
122122
system "git checkout Makefile" # Work around a weird bug on FreeBSD
123123
end
124124
end

release/x86_64-freebsd-11/Vagrantfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Vagrant.configure(2) do |config|
1212

1313
# Every Vagrant development environment requires a box. You can search for
1414
# boxes at https://atlas.hashicorp.com/search.
15-
config.vm.box = "freebsd/FreeBSD-11.0-RELEASE-p1"
15+
config.vm.box = "freebsd/FreeBSD-11.0-STABLE"
1616

1717
# Disable automatic box update checking. If you disable this, then
1818
# boxes will only be checked for updates when the user runs

0 commit comments

Comments
 (0)