Revert "Add a group around V8 static libraries"

This reverts commit 9977436.

It seems that groups are not supported in macOS' ld

Author: ignisf

CHANGELOG.md

@@ -5,7 +5,6 @@
   instead added as a submodule in the current tree
 * Hooks are no longer ran after syncing V8's upstream dependencies
 * Reordered libraries in accordance with the V8 wiki
-* Added groups around the library flags in accordance with the V8 wiki
 
 ### v5.9.211.38.0, v5.9.211.38.1 - 2017-07-26
 

ext/libv8/location.rb

@@ -29,7 +29,7 @@ def install!
 
       def configure(context = MkmfContext.new)
         context.incflags.insert 0, Libv8::Paths.include_paths.map{ |p| "-I#{p}" }.join(" ")  + " "
-        context.ldflags.insert 0, "-Wl,--start-group " + Libv8::Paths.object_paths.join(" ") + " -Wl,--end-group "
+        context.ldflags.insert 0, Libv8::Paths.object_paths.join(" ") + " "
       end
 
       def verify_installation!

spec/location_spec.rb

@@ -64,7 +64,7 @@
     end
 
     it "prepends the locations of any libv8 objects on the the ldflags" do
-      expect(@context.ldflags).to eql "-Wl,--start-group /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_base.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libbase.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_snapshot.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libplatform.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libsampler.a -Wl,--end-group -lobjc -lpthread"
+      expect(@context.ldflags).to eql "/foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_base.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libbase.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_snapshot.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libplatform.a /foo\\ bar/v8/out/x64.release/obj.target/tools/gyp/libv8_libsampler.a -lobjc -lpthread"
     end
   end
 end