Merge pull request #344 from ruby-rdf/feature/Informative-Deprecations

Feature/informative deprecations

Author: gkellogg

lib/rdf.rb

@@ -94,10 +94,7 @@ def self.Node(*args, &block)
   # @param (see RDF::URI#initialize)
   # @return [RDF::URI]
   def self.URI(*args, &block)
-    case uri = args.first
-      when uri.respond_to?(:to_uri) then uri.to_uri
-      else URI.new(*args, &block)
-    end
+    (uri = args.first).respond_to?(:to_uri) ? uri.to_uri : URI.new(*args, &block)
   end
 
   ##

lib/rdf/mixin/enumerable.rb

@@ -765,7 +765,10 @@ def dump(*args, **options)
     def method_missing(meth, *args)
       case meth
       when :to_hash
-        warn "[DEPRECATION] Enumerable#to_hash is deprecated, use Enumerable#to_h instead. Called from #{Gem.location_of_caller.join(':')}"
+        warn "[DEPRECATION] RDF::Enumerable#to_hash is deprecated, use RDF::Enumerable#to_h instead.\n" +
+             "This is due to the introduction of keyword arugments that attempt to turn the last argument into a hash using #to_hash.\n" +
+             "This can be avoided by explicitly passing an options hash as the last argument.\n" +
+             "Called from #{Gem.location_of_caller.join(':')}"
         return self.to_h
       end
       writer = RDF::Writer.for(meth.to_s[3..-1].to_sym) if meth.to_s[0,3] == "to_"

lib/rdf/model/statement.rb

@@ -426,7 +426,10 @@ def reified(subject: nil, id: nil, graph_name: nil)
     def method_missing(meth, *args)
       case meth
       when :to_hash
-        warn "[DEPRECATION] Statement#to_hash is deprecated, use Statement#to_h instead. Called from #{Gem.location_of_caller.join(':')}"
+        warn "[DEPRECATION] RDF::Statement#to_hash is deprecated, use RDF::Statement#to_h instead.\n" +
+             "This is due to the introduction of keyword arugments that attempt to turn the last argument into a hash using #to_hash.\n" +
+             "This can be avoided by explicitly passing an options hash as the last argument.\n" +
+             "Called from #{Gem.location_of_caller.join(':')}"
         self.to_h
       else
         super

lib/rdf/model/uri.rb

@@ -1299,7 +1299,10 @@ def format_authority
     def method_missing(meth, *args)
       case meth
       when :to_hash
-        warn "[DEPRECATION] RDF::URI#to_hash is deprecated, use RDF::URI#to_h instead. Called from #{Gem.location_of_caller.join(':')}"
+        warn "[DEPRECATION] RDF::URI#to_hash is deprecated, use RDF::URI#to_h instead.\n" +
+             "This is due to the introduction of keyword arugments that attempt to turn the last argument into a hash using #to_hash.\n" +
+             "This can be avoided by explicitly passing an options hash as the last argument.\n" +
+             "Called from #{Gem.location_of_caller.join(':')}"
         self.to_h
       else
         super

lib/rdf/query/solution.rb

@@ -277,7 +277,10 @@ def inspect
     #   @return [RDF::Term]
     def method_missing(name, *args, &block)
       if name == :to_hash
-        warn "[DEPRECATION] Solution#to_hash is deprecated, use Solution#to_h instead. Called from #{Gem.location_of_caller.join(':')}"
+        warn "[DEPRECATION] RDF::Query::Solution#to_hash is deprecated, use RDF::Query::Solution#to_h instead.\n" +
+             "This is due to the introduction of keyword arugments that attempt to turn the last argument into a hash using #to_hash.\n" +
+             "This can be avoided by explicitly passing an options hash as the last argument.\n" +
+             "Called from #{Gem.location_of_caller.join(':')}"
         self.to_h
       elsif args.empty? && @bindings.has_key?(name.to_sym)
         @bindings[name.to_sym]

lib/rdf/query/variable.rb

@@ -229,7 +229,10 @@ def to_s
     #   @deprecated Use {#to_h} instead.
     def method_missing(name, *args, &block)
       if name == :to_hash
-        warn "[DEPRECATION] Variable#to_hash is deprecated, use Variable#to_h instead. Called from #{Gem.location_of_caller.join(':')}"
+        warn "[DEPRECATION] RDF::Query::Variable#to_hash is deprecated, use RDF::Query::Variable#to_h instead.\n" +
+             "This is due to the introduction of keyword arugments that attempt to turn the last argument into a hash using #to_hash.\n" +
+             "This can be avoided by explicitly passing an options hash as the last argument.\n" +
+             "Called from #{Gem.location_of_caller.join(':')}"
         self.to_h
       elsif args.empty? && @bindings.has_key?(name.to_sym)
         @bindings[name.to_sym]