move to requirements to VetiverModel

Author: isabelizimm

vetiver/pin_read_write.py

@@ -44,7 +44,10 @@ def vetiver_pin_write(board, model: VetiverModel, versioned: bool = True):
     >>> vetiver.vetiver_pin_write(model_board, v)
     """
     if not board.allow_pickle_read:
-        raise NotImplementedError  # must be pickle-able
+        raise ValueError(
+            "board does not allow pickled models. Set "
+            "allow_pickle_read to True on board creation."
+        )
 
     inform(
         _log,
@@ -61,8 +64,6 @@ def vetiver_pin_write(board, model: VetiverModel, versioned: bool = True):
     if isinstance(model.metadata, dict):
         model.metadata = VetiverMeta.from_dict(model.metadata)
 
-    required_pkgs = get_board_pkgs(board) + model.metadata.required_pkgs
-
     board.pin_write(
         model.model,
         name=model.model_name,
@@ -71,7 +72,7 @@ def vetiver_pin_write(board, model: VetiverModel, versioned: bool = True):
         metadata={
             "user": model.metadata.user,
             "vetiver_meta": {
-                "required_pkgs": required_pkgs,
+                "required_pkgs": model.metadata.required_pkgs,
                 "prototype": None if not model.prototype else model.prototype().json(),
                 "python_version": None
                 if not model.metadata.python_version
@@ -117,7 +118,7 @@ def vetiver_pin_read(board, name: str, version: str = None) -> VetiverModel:
     return v
 
 
-def get_board_pkgs(board) -> List[str]:
+def _get_board_pkgs(board) -> List[str]:
     """
     Extract packages required for pin board authorization
 
@@ -144,7 +145,7 @@ def get_board_pkgs(board) -> List[str]:
         return ["gcsfs"]
     else:
         warnings.warn(
-            f"required packages unknown for protocol: {prot}, "
-            "add to model's metadata to ensure they are exported"
+            f"required packages unknown for board protocol: {prot}, "
+            "add to model's metadata to export"
         )
         return []

vetiver/vetiver_model.py

@@ -1,6 +1,7 @@
 import json
 from warnings import warn
 from vetiver.handlers.base import create_handler
+from .pin_read_write import _get_board_pkgs
 
 
 class NoModelAvailableError(Exception):
@@ -52,8 +53,6 @@ class VetiverModel:
     Parameter `ptype_data` was changed to `prototype_data`. Handling of `ptype_data`
     will be removed in a future version.
 
-
-
     Examples
     -------
     >>> from vetiver import mock, VetiverModel
@@ -101,19 +100,15 @@ def from_pin(cls, board, name: str, version: str = None):
 
         if "vetiver_meta" in meta.user:
             get_prototype = meta.user.get("vetiver_meta").get("prototype", None)
-            required_pkgs = meta.user.get("vetiver_meta").get("required_pkgs", None)
+            required_pkgs = meta.user.get("vetiver_meta").get(
+                "required_pkgs", None
+            ) + _get_board_pkgs(board)
             python_version = meta.user.get("vetiver_meta").get("python_version", None)
             meta.user.pop("vetiver_meta")
+        # old pin type
         else:
-            # ptype = meta.user.get("ptype", None)
-
             get_prototype = meta.user.get("ptype")
-            # elif meta.user.get("prototype"):
-            #     get_prototype = meta.user.get("prototype")
-            # else:
-            #     get_prototype = None
-
-            required_pkgs = meta.user.get("required_pkgs")
+            required_pkgs = meta.user.get("required_pkgs") + _get_board_pkgs(board)
             python_version = meta.user.get("python_version")
 
         return cls(